Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf_25: 25.4 -> 25.5 #342890

Merged
merged 1 commit into from
Oct 16, 2024
Merged

protobuf_25: 25.4 -> 25.5 #342890

merged 1 commit into from
Oct 16, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 18, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/protocolbuffers/protobuf/releases/tag/v25.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as draft September 18, 2024 22:18
@GaetanLepage GaetanLepage changed the base branch from master to staging October 13, 2024 14:01
@GaetanLepage GaetanLepage marked this pull request as ready for review October 13, 2024 14:01
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Oct 13, 2024 •
edited by SuperSandro2000
Loading

@ofborg eval

@GaetanLepage
Copy link
Contributor Author

The eval fails with:

nix-env did not evaluate cleanly:
 ["trace: evaluation warning: lib.replaceChars is a deprecated alias of lib.replaceStrings."]

Not sure if it's a problem related to this PR.

@SuperSandro2000
Copy link
Member

Nope and it should be fixed a few minutes ago on staging

@GaetanLepage
Copy link
Contributor Author

Nope and it should be fixed a few minutes ago on staging

Looks good now

@GaetanLepage GaetanLepage merged commit 4721a7f into NixOS:staging Oct 16, 2024
28 checks passed
@GaetanLepage GaetanLepage deleted the protobuf_25 branch October 16, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @SuperSandro2000