xmake: 2.9.4 -> 2.9.5

[rennsax]

Description of changes

Xmake is actually broken in Nixpkgs. See #342966.

I'm surprised that this simple derivation "just works" - on my MacBook 2021 (aarch64-darwin), on my NixOS virtual machine (aarch64-linux) and on my lab's server (x86_64-linux).

However I'm not sure if the derivation is generic enough. Maybe more tests needed.

Here is the behavior of xmake:

$ xmake create -l c -P ./hello
create hello ...
  [+]: xmake.lua
  [+]: src/main.c
  [+]: .gitignore
create ok!
$ cd hello
$ xmake
checking for platform ... linux
checking for architecture ... x86_64
[ 50%]: cache compiling.release src/main.c
[ 75%]: linking.release hello
[100%]: build ok, spent 1.287s
$ xmake --version
xmake v2.9.5+19800101, A cross-platform build utility based on Lua
Copyright (C) 2015-present Ruki Wang, tboox.org, xmake.io
                         _
    __  ___ __  __  __ _| | ______
    \ \/ / |  \/  |/ _  | |/ / __ \
     >  <  | \__/ | /_| |   <  ___/
    /_/\_\_|_|  |_|\__ \|_|\_\____|
                         by ruki, xmake.io

    👉  Manual: https://xmake.io/#/getting_started
    🙏  Donate: https://xmake.io/#/sponsor

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[rennsax]

ping @wineee

[Atemu]

@wineee can I leave this one to you? You appear to have experience with this package.

[rennsax]

@wineee If you DO NOT want to use the submodules in xmake repo to build it (which is totally correct, just like the author of xmake did for Homebrew), please at least add broken = true to xmake. They are not well-tested and only available on your environment. And you should not add xmake-core-sv to Nixpkgs, because there is already libsv. Leave them in your NUR.

[rennsax]

I've tried to build xmake with dependencies already available on Nixpkgs. And frankly speaking it's really ugly and unnecessary, Because the author of xmake uses such a hacky build system.

For example, tboox/tbox is a C library, and it has specified configure options for xmake. Hard-coding these options like you did in tbox/default.nix is not generic, and you cannot expect the upstream keeps the same options all the time.

Not to say, adding a package like xmake-core-sv in the top-level is totally unnecessary.

The goal of Nixpkgs is not making software packing so idiosyncratic and complex. It will tremendously hurt user experience when they find the software is either unavailable, or behave weirdly compared to the same one provided by another package manager.

[wineee]

Please rebase and change commit message to: xmake: 2.9.4 -> 2.9.5

[rennsax]

Done. Thanks for reviewing.

[wineee]

Build failed on x86_64-darwin:

In file included from core/src/tbox/tbox/src/tbox/platform/file.c:41:
core/src/tbox/tbox/src/tbox/platform/posix/file.c:697:34: error: use of undeclared identifier 'UTIME_OMIT'
            else ts[0].tv_nsec = UTIME_OMIT;
                                 ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:699:34: error: use of undeclared identifier 'UTIME_OMIT'
            else ts[1].tv_nsec = UTIME_OMIT;
                                 ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:700:19: error: call to undeclared function 'utimensat'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            ok = !utimensat(AT_FDCWD, path, ts, 0);
                  ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:715:38: error: use of undeclared identifier 'UTIME_OMIT'
                else ts[0].tv_nsec = UTIME_OMIT;
                                     ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:717:38: error: use of undeclared identifier 'UTIME_OMIT'
                else ts[1].tv_nsec = UTIME_OMIT;
                                     ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:718:23: error: call to undeclared function 'futimens'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                ok = !futimens(tb_file2fd(file), ts);
                      ^
6 errors generated.

https://logs.ofborg.org/?key=nixos/nixpkgs.343185&attempt_id=e2479983-f76a-4d28-a737-c1bc19a2ce6b

[rennsax]

Build failed on x86_64-darwin:

In file included from core/src/tbox/tbox/src/tbox/platform/file.c:41:
core/src/tbox/tbox/src/tbox/platform/posix/file.c:697:34: error: use of undeclared identifier 'UTIME_OMIT'
            else ts[0].tv_nsec = UTIME_OMIT;
                                 ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:699:34: error: use of undeclared identifier 'UTIME_OMIT'
            else ts[1].tv_nsec = UTIME_OMIT;
                                 ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:700:19: error: call to undeclared function 'utimensat'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            ok = !utimensat(AT_FDCWD, path, ts, 0);
                  ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:715:38: error: use of undeclared identifier 'UTIME_OMIT'
                else ts[0].tv_nsec = UTIME_OMIT;
                                     ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:717:38: error: use of undeclared identifier 'UTIME_OMIT'
                else ts[1].tv_nsec = UTIME_OMIT;
                                     ^
core/src/tbox/tbox/src/tbox/platform/posix/file.c:718:23: error: call to undeclared function 'futimens'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                ok = !futimens(tb_file2fd(file), ts);
                      ^
6 errors generated.

logs.ofborg.org?key=nixos/nixpkgs.343185&attempt_id=e2479983-f76a-4d28-a737-c1bc19a2ce6b

Surprising 🙁 I'll test it later.

[rennsax]

Find the reason and a related post: #338695

utimensat requires macOS SDK >= 10.13 but Nixpkgs will stick to 10.12.2 for x86_64-darwin until the release of 25.05.

Solution: https://github.com/NixOS/nixpkgs/blob/master/doc/stdenv/platform-notes.chapter.md

diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 4fb008387e5c..50305ee41136 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -18916,7 +18916,7 @@ with pkgs;
 
   webdis = callPackage ../development/tools/database/webdis { };
 
-  xmake = callPackage ../development/tools/build-managers/xmake {
+  xmake = darwin.apple_sdk_11_0.callPackage ../development/tools/build-managers/xmake {
     inherit (darwin.apple_sdk.frameworks) CoreServices;
   };

@wineee Add a new commit, or rebase and override the old commits?

[wineee]

Add a new commit: xmake: fix buildon x86_64 darwin

Also should use same sdk for CoreServices:

--     inherit (darwin.apple_sdk.frameworks) CoreServices;
++     inherit (darwin.apple_sdk_11_0.frameworks) CoreServices;

[rennsax]

Thanks