-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubo-migrator: add migration from 15 to 16 #344265
Conversation
f1f481d
to
26c6f53
Compare
I decided to now also fetch the source of each migration from their respective git tag, as upstream intended. |
6cc7f4e
to
6f46b53
Compare
6f46b53
to
c47bb3a
Compare
I resolved the conflict. |
Beside a now needed rebase, what is needed for this to be merged to the repo? Kubo is currently releasing a RC for the v0.32 and this PR is needed since the PR for upgrading to v0.30 has been open (more than 1 month ago now). @Luflosi I guess you don't have merge right for this? |
Tested to migrate from repo version 15 to 16, works fine, thanks ! Trivial rebase still needed. |
- Migrate to pkgs/by-name - Format with nixfmt-rfc-style - Make it possible to remove support for very old migrations in the future by increasing the `minRepoVersion` parameter - Rename kubo-migrator-all-fs-repo-migrations to kubo-fs-repo-migrations since it may no longer include all migrations - Add an alias for kubo-migrator-all-fs-repo-migrations to keep backwards compatibility - Update descriptions to differentiate between kubo-migrator and kubo-migrator-unwrapped and better describe the purpose of the migrator - Add a description to every individual migration - Add a description to kubo-fs-repo-migrations - Fetch the source code of the individual migrations from their specific Git tags, like upstream intends - Enable tests for some migrations - Check that the migrations don't crash on startup - Mark two broken migrations as broken. They are not compatible with the latest Go versions and upstream is not interested in fixing this - Change code to allow most updates to be done by only changing three lines (add new version and change git tag and hash) - Add a stub for any disabled or broken migration to prevent downloading unsigned binaries from the internet, see ipfs/fs-repo-migrations#148 (comment) and ipfs/fs-repo-migrations#188 - Use `lib.getExe` instead of hardcoding the binary name in the kubo NixOS module - Use `substituteInPlace` with `--replace-fail` instead of `--replace`
c47bb3a
to
ca26219
Compare
I rebased. This should be ready for merging.
No.
Thanks. |
Then I guess it's time to poke random people to find somebody with write access? :/ @wegank: I see that you are a member of the NixOS org, would you be able to merge this PR? |
Thank you @wegank 🙏 |
Thanks! |
Description of changes
The latest migration is required by the latest Kubo version 0.30.0.
I also rewrote the migration code:
minRepoVersion
parameterlib.getExe
instead of hardcoding the binary name in the kubo NixOS modulesubstituteInPlace
with--replace-fail
instead of--replace
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.