-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboardio keyboard support #344905
base: master
Are you sure you want to change the base?
Add keyboardio keyboard support #344905
Conversation
607de25
to
ec96525
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4693 |
I have this in my config: https://code.maralorn.de/maralorn/config/src/branch/main/nixos/roles/clients/chrysalis.nix and my chrysalis starts and works fine. Were you aware of that approach? Is your solution here better? |
No, yours seems much cleaner. I would have tried that, had I known.
Not sure, probably not. If the chrysalis package has all the required udev rules, then there is no point in hand-copying them from complicated-to-explain sources. Also, this set of rules would then likely be maintained. Do you think it's worth adding your solution as the config option I've declared here? Because if it works for me as well, that's what I'd do. |
A config option would be great for discoverability so I am in favor. Does not seem very important either, though … |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.