Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar: add systemdSupport input #345107

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

Scrumplex
Copy link
Member

Description of changes

This was raised in #340874 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 28, 2024
@Scrumplex Scrumplex force-pushed the pkgs/waybar/add-systemd-support branch 2 times, most recently from 039cdf3 to 18faf17 Compare September 28, 2024 13:57
@khaneliman
Copy link
Contributor

Also mentioned in the original PR #242728 (comment). Thanks for handling this.

@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 345107 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package built:
  • waybar

@khaneliman
Copy link
Contributor

Also builds fine with the overrides from #340874 (comment)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 28, 2024
@Scrumplex Scrumplex added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 28, 2024
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@JohnRTitor JohnRTitor force-pushed the pkgs/waybar/add-systemd-support branch from 18faf17 to 5fcc133 Compare September 29, 2024 12:27
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied the suggested changes, will merge once CI passes.

@JohnRTitor JohnRTitor self-assigned this Sep 29, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 29, 2024
@JohnRTitor JohnRTitor merged commit 007e916 into NixOS:master Sep 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants