-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waybar: add systemdSupport input #345107
Merged
JohnRTitor
merged 2 commits into
NixOS:master
from
Scrumplex:pkgs/waybar/add-systemd-support
Sep 29, 2024
Merged
waybar: add systemdSupport input #345107
JohnRTitor
merged 2 commits into
NixOS:master
from
Scrumplex:pkgs/waybar/add-systemd-support
Sep 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Sep 28, 2024
Scrumplex
force-pushed
the
pkgs/waybar/add-systemd-support
branch
2 times, most recently
from
September 28, 2024 13:57
039cdf3
to
18faf17
Compare
Also mentioned in the original PR #242728 (comment). Thanks for handling this. |
Result of 1 package blacklisted:
1 package built:
|
Also builds fine with the overrides from #340874 (comment) |
khaneliman
approved these changes
Sep 28, 2024
ofborg
bot
requested review from
Synthetica9,
khaneliman,
rodrgz,
minijackson,
lovesegfault and
FlorianFranzen
September 28, 2024 15:18
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Sep 28, 2024
Scrumplex
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
labels
Sep 28, 2024
JohnRTitor
reviewed
Sep 29, 2024
JohnRTitor
reviewed
Sep 29, 2024
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
JohnRTitor
force-pushed
the
pkgs/waybar/add-systemd-support
branch
from
September 29, 2024 12:27
18faf17
to
5fcc133
Compare
JohnRTitor
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have applied the suggested changes, will merge once CI passes.
wegank
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
12.approvals: 2
This PR was reviewed and approved by two reputable people
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This was raised in #340874 (comment)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.