Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdns: 4.9.1 -> 4.9.2 #345153

Merged
merged 5 commits into from
Oct 5, 2024
Merged

pdns: 4.9.1 -> 4.9.2 #345153

merged 5 commits into from
Oct 5, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Sep 28, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from Mic92 and disassembler September 28, 2024 19:09
@NickCao NickCao changed the title pdns: make use of lib.{enable,with}Feature and __structuredAttrs pdns: 4.9.1 -> 4.9.2 Oct 2, 2024
@NickCao NickCao requested a review from JohnRTitor October 5, 2024 13:42
@JohnRTitor JohnRTitor merged commit 920ead1 into NixOS:master Oct 5, 2024
25 of 26 checks passed
@NickCao NickCao deleted the pdns branch October 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

@disassembler disassembler Awaiting requested review from disassembler

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickCao @wolfgangwalther @JohnRTitor