Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tslib: init at 1.23 #345302

Merged
merged 1 commit into from
Oct 7, 2024
Merged

tslib: init at 1.23 #345302

merged 1 commit into from
Oct 7, 2024

Conversation

Sh0g0-1758
Copy link
Member

@Sh0g0-1758 Sh0g0-1758 commented Sep 29, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sh0g0-1758
Copy link
Member Author

@zimward @JulienMalka

zimward
zimward approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, though i am still not sure about the finalAttrs thing but that should not be a blocker as there is no consensus about those patterns.

pkgs/by-name/ts/tslib/package.nix Outdated Show resolved Hide resolved
@Sh0g0-1758
Copy link
Member Author

@zimward , this good to merge now ?

@zimward
Copy link
Contributor

zimward commented Oct 7, 2024

I have no further nits.

JulienMalka
JulienMalka approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JulienMalka JulienMalka merged commit 291dc4c into NixOS:master Oct 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimward zimward zimward approved these changes

@JulienMalka JulienMalka JulienMalka approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sh0g0-1758 @zimward @JulienMalka