smassh: 3.1.4 -> 3.1.6

[khaneliman]

Follow up to #345228 with similar fix since #344813 broke it.

EDIT: Also bumping versions released during PR

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[khaneliman]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 345631

---

x86_64-linux

✅ 2 packages built:

• smassh
• smassh.dist

---

x86_64-darwin

✅ 2 packages built:

• smassh
• smassh.dist

---

aarch64-darwin

✅ 2 packages built:

• smassh
• smassh.dist

[kraanzu]

Hi @khaneliman, The dooit PR had some tests issue right due to textual version mismatch? Instead of pinning textual version, I can update the repo instead

[khaneliman]

Hi @khaneliman, The dooit PR had some tests issue right due to textual version mismatch? Instead of pinning textual version, I can update the repo instead

dooit and smassh both got broken at runtime with the textual 81 update.

File "/nix/store/y40ddcl2k6d5lqsdhh14d9xylqy16ayf-python3.11-textual-0.81.0/lib/python3.11/site-packages/textual/message_pump.py", line 109, in __new__
    class_obj = super().__new__(cls, name, bases, class_dict, **kwargs)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/y40ddcl2k6d5lqsdhh14d9xylqy16ayf-python3.11-textual-0.81.0/lib/python3.11/site-packages/textual/app.py", line 785, in __init_subclass__
    raise ValueError(
ValueError: SCREENS should contain a Screen type or callable, not an instance (got instance of MainScreen for 'main')

[khaneliman]

It can be updated upstream to support a newer version of textual, but we just need to unbreak it with the current version of the package here, too.

[kraanzu]

Yep. I'm working on it (will push an update in a few minutes), I see that on nixos stable, the textual version is 0.53 but on unstable its the latest (0.81) this will be handled automatically.

[kraanzu]

but we just need to unbreak it with the current version of the package here, too.

Ah I see. Sure

I also pushed a newer version so we can also add an update for that

[khaneliman]

@kraanzu figured you want to be a maintainer for this so i added you

[kraanzu]

Thanks @khaneliman, just one more change, you need to replace appdirs with platformfirs since appdirs is not maintained anymore

[khaneliman]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 345631

---

x86_64-linux

❌ 2 packages failed to build:

• smassh
• smassh.dist

---

x86_64-darwin

❌ 2 packages failed to build:

• smassh
• smassh.dist

---

aarch64-darwin

❌ 2 packages failed to build:

• smassh
• smassh.dist

[kraanzu]

Hmmm...what went wrong here

[kraanzu]

Hi @khaneliman , I think I found the issue and fixed I. You'll need to modify the version to 3.1.6 and change the hash accordingly. Other stuff should be fine

[khaneliman]

Hmmm...what went wrong here

sorry, made a tweak before going to bed and had a typo in the relaxedDeps

[khaneliman]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 345631

---

x86_64-linux

✅ 2 packages built:

• smassh
• smassh.dist

---

x86_64-darwin

✅ 2 packages built:

• smassh
• smassh.dist

---

aarch64-darwin

✅ 2 packages built:

• smassh
• smassh.dist

[khaneliman]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 345631

---

x86_64-linux

✅ 2 packages built:

• smassh
• smassh.dist

---

x86_64-darwin

✅ 2 packages built:

• smassh
• smassh.dist

---

aarch64-darwin

✅ 2 packages built:

• smassh
• smassh.dist

[kraanzu]

Awesome. It works now !