xdg-desktop-portal-gtk: Enable all default portals unconditionally #345979
Conversation
This will fix the conflict when another DE using the full `xdg-desktop-portal-gtk` is enabled simultaneously with Cinnamon. There will no longer be conflicts at runtime since the portals are now configured by `cinnamon-common` in `xdg.portal.configPackages`. The added closure size should be negligible, as most of the packages are also used by Cinnamon.
This will fix the conflict when another DE using the full `xdg-desktop-portal-gtk` is enabled simultaneously with Deepin. Currently, our Deepin uses `gtk` as the preferred default implementation for all portals so presumably the duplicate portals should not have been disabled anyway. The added closure size should be negligible, as most of the packages are probably also used by Deepin transitively.
This will fix the conflict when another DE using the full `xdg-desktop-portal-gtk` is enabled simultaneously with GNOME. There will not be conflicts at runtime since the portals have been configured by `gnome-session` in `xdg.portal.configPackages` for a while now. There will be minimal effect on system closure as all the extra x-d-p dependencies are also used by GNOME platform.
In 80ea989 we updated to x-d-p-gtk 1.10.0, in which some portals were extracted to x-d-p-gnome and were disabled by default in x-d-p-gtk. This was continued with x-d-p-gtk 1.15 bump in 6d64606, which default-enabled all portals because of port to Meson’s auto features. But I do not think the conflict between portal implementations from x-d-p-gtk and x-d-p-gnome has ever been an issue at runtime – since `gnome` comes before `gtk` alphabetically, the `gnome` portal should have been always preferred when both were available. And since x-d-p 1.17.0, the portal implementation conflicts are a complete non-issue, as desktop environments can configure which implementation to use for each portal. Since the benefits of disabling the extra portals are minimal and can lead to conflicts when multiple DEs are enable, we have stopped DEs from doing that in parent commits. This makes the argument unused so let’s remove it.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
This solves my build failing with hyprland and gnome enabled. I have the same error as #345733 without this fix. |
wegank
added
the
12.approvals: 3+
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
It's a shame that most DEs now draw in a whole bag of gnome dependencies including the entire settings daemon. Are the gnome specific things of any use on other distro? I doubt it and they increase closure size dramatically. |
This was always the default case. Only GNOME, Deepin and Cinnamon were disabling pulling in the extra dependencies.
Other distros have FHS so they can just pick the GSettings schemas from there if they are present. We do not really need the whole package, just the settings schemas so if someone managed to create a dummy package it might be fine. Or maybe we could drop those dependencies since DEs that use gnome-settings-daemon might not even use the settings portal implementation from |
I wanted to use that for Plasma, too, to avoid all the extra dependencies. IMO it is not acceptable for plasma to depend on so many gnome things for a feature which doesn't even work there or are not even required.
|
Things done
xdg-desktop-portal-gtk: Enable all default portals unconditionally
In 80ea989 we updated to x-d-p-gtk 1.10.0, in which some portals were extracted to x-d-p-gnome and were disabled by default in x-d-p-gtk. This was continued with x-d-p-gtk 1.15 bump in 6d64606, which default-enabled all portals because of port to Meson’s auto features.
But I do not think the conflict between portal implementations from x-d-p-gtk and x-d-p-gnome has ever been an issue at runtime – since
gnomecomes beforegtkalphabetically, thegnomeportal should have been always preferred when both were available.And since x-d-p 1.17.0, the portal implementation conflicts are a complete non-issue, as desktop environments can configure which implementation to use for each portal.
Since the benefits of disabling the extra portals are minimal and can lead to conflicts when multiple DEs are enable, we have stopped DEs from doing that in parent commits. This makes the argument unused so let’s remove it.
Fixes: #345733
cc @wineee @bobby285271 @Frontear
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.