Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python313Packages.mypy: disable #346175

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

natsukium
Copy link
Member

mypy does not support python313 yet

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

mypy does not support python313 yet
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 3, 2024
@natsukium natsukium merged commit 63e0b95 into NixOS:master Oct 6, 2024
23 checks passed
@natsukium natsukium deleted the mypy/python313 branch October 6, 2024 07:14
@bakaq
Copy link
Contributor

bakaq commented Oct 25, 2024

I'm pretty sure what they mean in python/mypy#17264 is that mypy still can't analyse all features in Python 3.13, but it can still run under the Python 3.13 interpreter, which is what I think is relevant here. Feel free to correct me if that is not the case.

I stumbled on this because I found out that I can't use Flask with Python 3.13 because it has a dependency on mypy 1.11.

@natsukium
Copy link
Member Author

Note that python313 is supported by mypy1.12 or later, and it was released after this PR.
https://github.com/python/mypy/blob/master/CHANGELOG.md#basic-support-for-python-313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants