mpvScripts.mpv-image-viewer: init at 0-unstable-2023-03-03

[uninsane]

packages mpv-image-viewer. these are all independent, managed under one umbrella project. example usage:

$ nix-shell -E 'mpv.override { scripts = [ mpvScripts.mpv-image-viewer.image-positioning ]; }'
[nix-shell]$ echo 'CTRL+MBTN_LEFT script-binding drag-to-pan' | mpv --input-conf=/dev/stdin --pause 'https://github.com/NixOS/nixos-artwork/blob/master/wallpapers/NixOS-Gradient-grey.png?raw=true'

# zoom the image with default mpv controls (control + mouse wheel)
# and observe that holding control + left mouse button now allows to pan when zoomed in,
# whereas stock `mpv` does not implement any panning function

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nbraud]

I merged #359625 into this PR branch, locally, and can confirm everything works (and the generic tests pass)

@FliegendeWurst, shall I push the merge here so the merge conflict with that other PR is already resolved, and this can be merged right after #359625 ?

PS: sorry, I meant to address this to the PR's author 😅

[FliegendeWurst]

You can do that, or just rebase after that one is merged. It will not delay this PR much either way

[nbraud]

Rebased now that the blocker was merged.

[nbraud]

Sorry for missing all of that on first review, I think I just stopped when I noticed the generic tests were missing 😅

[uninsane]

removed the scope, copied descriptions from upstream's readme (equalizer has no description): https://github.com/occivink/mpv-image-viewer/blob/master/README.md#scripts

feel free to suggest alternate descriptions if that's important to you. they're slightly long for typical nixpkgs descriptions, but not enough that it bothered me personally.

[nbraud]

feel free to suggest alternate descriptions if that's important to you.

I'm not terribly picky here, I just felt having per-script descriptions would be important for discoverability (e.g. on search.nixos.org) and for users to quickly see what the script is supposed to do (when deciding whether to try it)

they're slightly long for typical nixpkgs descriptions, but not enough that it bothered me personally.

They seem fine to me as well; FYI, for cases where it is an issue I'd keep it to a single, short sentence, and plonk the long-form explanation in meta.longDescription.

[nbraud]

Addressed merge conflict

[nbraud]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 347323

---

aarch64-darwin

✅ 7 packages built:

• mpvScripts.mpv-image-viewer.detect-image
• mpvScripts.mpv-image-viewer.equalizer
• mpvScripts.mpv-image-viewer.freeze-window
• mpvScripts.mpv-image-viewer.image-positioning
• mpvScripts.mpv-image-viewer.minimap
• mpvScripts.mpv-image-viewer.ruler
• mpvScripts.mpv-image-viewer.status-line

[nbraud]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 347323

---

x86_64-linux

✅ 7 packages built:

• mpvScripts.mpv-image-viewer.detect-image
• mpvScripts.mpv-image-viewer.equalizer
• mpvScripts.mpv-image-viewer.freeze-window
• mpvScripts.mpv-image-viewer.image-positioning
• mpvScripts.mpv-image-viewer.minimap
• mpvScripts.mpv-image-viewer.ruler
• mpvScripts.mpv-image-viewer.status-line

[uninsane]

squashed the commits

[nbraud]

Eval still passes after merge (on the new GH Action setup) so I'll go ahead without waiting for @ofborg

squashed the commits

FWIW, I find a squash-merge preferable, since it avoids re-triggering CI etc. :3