Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/srcOnly: init #347548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests/srcOnly: init #347548

wants to merge 1 commit into from

Conversation

Pandapip1
Copy link
Contributor

Adds a basic test to ensure that srcOnly functions correctly.

This is the first NixOS test I've written, and it's likely I've misunderstood something. If so, please let me know what's wrong and needs fixing!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@@ -927,6 +927,7 @@ in {
spacecookie = handleTest ./spacecookie.nix {};
spark = handleTestOn [ "x86_64-linux" "aarch64-linux" ] ./spark {};
sqlite3-to-mysql = handleTest ./sqlite3-to-mysql.nix {};
srcOnly = pkgs.callPackage ./srcOnly.nix {};
Copy link
Member

@Artturin Artturin Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a nixos/vm test, put it in pkgs/test/default.nix and pkgs/build-support/src-only/test.nix instead.

@Pandapip1 Pandapip1 marked this pull request as draft October 10, 2024 20:05
@Pandapip1
Copy link
Contributor Author

Why are there 0 rebuilds? Shouldn't the test be built by ofborg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants