Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.plotly: disable checks on darwin, unbreak #347567

Merged
merged 2 commits into from
Oct 10, 2024
Merged

python312Packages.plotly: disable checks on darwin, unbreak #347567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3059261
python312Packages.plotly: disable checks on darwin, unbreak
pbsds Oct 9, 2024
31a40d3
python312Packages.plotly: deselect 2 tests on linux, unbreak python3.11
pbsds Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkgs/development/python-modules/plotly/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
lib,
stdenv,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv,

buildPythonPackage,
fetchFromGitHub,
setuptools,
Expand Down Expand Up @@ -70,6 +71,9 @@ buildPythonPackage rec {
scikit-image
];

# the check inputs are broken on darwin
doCheck = !stdenv.hostPlatform.isDarwin;

Comment on lines +74 to +76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# the check inputs are broken on darwin
doCheck = !stdenv.hostPlatform.isDarwin;
optional-dependencies = {
orca = [ orca ];
};

and change nativeCheckInputs to checkInputs

disabledTests = [
# FAILED plotly/matplotlylib/mplexporter/tests/test_basic.py::test_legend_dots - AssertionError: assert '3' == '2'
"test_legend_dots"
Expand Down Expand Up @@ -116,6 +120,9 @@ buildPythonPackage rec {
"test_dependencies_not_imported"
# FAILED test_init/test_lazy_imports.py::test_lazy_imports - AssertionError: assert 'plotly' not in {'IPython': <module 'IPython' from '...
"test_lazy_imports"
# requires vaex and polars, vaex is not packaged
"test_build_df_from_vaex_and_polars"
"test_build_df_with_hover_data_from_vaex_and_polars"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"test_build_df_with_hover_data_from_vaex_and_polars"
"test_build_df_with_hover_data_from_vaex_and_polars"
# Cannot launch kaleido as a subprocess. This would need a passthru test.
"test_kaleido_engine_to_image_returns_bytes"
"test_kaleido_fulljson"
"test_bytesio"
"test_png_renderer_mimetype"
"test_svg_renderer_show"
"test_pdf_renderer_show_override"
"test_mimetype_combination"
# Cannot run on systes without orca
"test_scraper"
"test_bytesio"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
"test_build_df_with_hover_data_from_vaex_and_polars"
"test_build_df_with_hover_data_from_vaex_and_polars"
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
# Cannot launch kaleido as a subprocess. This would need a passthru test.
"test_kaleido_engine_to_image_returns_bytes"
"test_kaleido_fulljson"
"test_bytesio"
"test_png_renderer_mimetype"
"test_svg_renderer_show"
"test_pdf_renderer_show_override"
"test_mimetype_combination"
# Cannot run on systes without orca
"test_scraper"
"test_bytesio"
];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pandapip1 that's even better.

];

pythonImportsCheck = [ "plotly" ];
Expand Down