postgresqlPackages.timescaledb: 2.14.2 -> 2.17.2; adopt, nixfmt; postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0 #348223

kirillrdy · 2024-10-13T09:21:43Z

Changes:

Things done

Add a 👍 reaction to pull requests you find important.

wolfgangwalther

Could you squash the two update commits + the "only supports postgresql 14" together in one commit and keep the maintainer + nixfmt commits separate?

wolfgangwalther · 2024-11-02T21:23:44Z

pkgs/servers/sql/postgresql/ext/timescaledb.nix

+    broken = versionOlder postgresql.version "14" ||
      # timescaledb supports PostgreSQL 17 from 2.17.0 on:
      # https://github.com/timescale/timescaledb/releases/tag/2.17.0
      # We can't upgrade to it, yet, because this would imply dropping support for


You can remove the whole part about versionAtLeast ... "17" and the 4 line comment now, I guess.

pkgs/servers/sql/postgresql/ext/timescaledb.nix

wolfgangwalther · 2024-11-02T21:25:15Z

pkgs/servers/sql/postgresql/ext/timescaledb.nix

+  lib,
+  stdenv,
+  fetchFromGitHub,
+  cmake,
+  postgresql,
+  openssl,
+  libkrb5,
+  nixosTests,
+  enableUnfree ? true,


While you have a diff because of nixfmt anyway, could you run a sort on those lines?

wolfgangwalther · 2024-11-02T21:30:21Z

Changes:

https://github.com/timescale/timescaledb/releases/tag/2.17.1

https://github.com/timescale/timescaledb/releases/tag/2.17.0

https://github.com/timescale/timescaledb/releases/tag/2.16.1

https://github.com/timescale/timescaledb/releases/tag/2.16.0

https://github.com/timescale/timescaledb/releases/tag/2.15.3

https://github.com/timescale/timescaledb/releases/tag/2.15.2

https://github.com/timescale/timescaledb/releases/tag/2.15.1

https://github.com/timescale/timescaledb/releases/tag/2.15.0

Are there any breaking changes (other than Postgres Version support) that we should take note of?

kirillrdy · 2024-11-06T09:41:04Z

@wolfgangwalther going to draft until after 24.11 branch off

wolfgangwalther · 2024-11-16T13:23:33Z

There is now also an update to timescaledb_toolkit available, which adds support for PG17. I suggest you bump that here, too.

I left both of them out of #356283. I did test that the new update script there, works for timescaledb and timescaledb_toolkit, too. Thus, we will be notified of new updates in the future.

Shall we go ahead with this now?

wolfgangwalther · 2024-11-16T13:28:58Z

I found the following things to note:

https://github.com/timescale/timescaledb/releases/tag/2.15.0

For self-hosted TimescaleDB v2.15.0 deployments only

After you run ALTER EXTENSION, you must run this SQL script. For more details, see the following pull requests Fix FK constraints for compressed chunks timescale/timescaledb#6797.
https://github.com/timescale/timescaledb/releases/tag/2.16.0

PostgreSQL 13 is no longer supported in TimescaleDB v2.16.

Those might need to be mentioned in our release notes, too?

kirillrdy · 2024-11-19T20:11:49Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348223

`x86_64-linux`

⏩ 4 packages marked as broken and skipped:

postgresql13JitPackages.timescaledb
postgresql13JitPackages.timescaledb-apache
postgresql13Packages.timescaledb
postgresql13Packages.timescaledb-apache

⏩ 1 package blacklisted:

nixos-install-tools

✅ 16 packages built:

postgresql14JitPackages.timescaledb
postgresql14JitPackages.timescaledb-apache
postgresql14Packages.timescaledb
postgresql14Packages.timescaledb-apache
postgresql15JitPackages.timescaledb
postgresql15JitPackages.timescaledb-apache
postgresql15Packages.timescaledb
postgresql15Packages.timescaledb-apache
postgresql16JitPackages.timescaledb
postgresql16JitPackages.timescaledb-apache
postgresql16Packages.timescaledb
postgresql16Packages.timescaledb-apache
postgresql17JitPackages.timescaledb
postgresql17JitPackages.timescaledb-apache
postgresql17Packages.timescaledb
postgresql17Packages.timescaledb-apache

wolfgangwalther

Could you squash the last commit "mention timescaledb" into the second commit "2.14.2 -> 2.17.1"?

Those changes really belong together, I think.

wolfgangwalther · 2024-11-19T20:21:55Z

pkgs/servers/sql/postgresql/ext/timescaledb.nix

+    broken =
+      versionOlder postgresql.version "14"
+      || (versionAtLeast postgresql.version "17" && version == "2.14.2");


Ah, sorry. The last line wasn't in the diff on my last comment, but the idea is to remove the whole "it's broken with v17". It's not anymore, right?

Suggested change

broken =

versionOlder postgresql.version "14"

|| (versionAtLeast postgresql.version "17" && version == "2.14.2");

broken = versionOlder postgresql.version "14";

wolfgangwalther · 2024-11-19T20:41:51Z

All good on darwin as well:

Result of nixpkgs-review pr 348223 run on aarch64-darwin 1

4 packages marked as broken and skipped:

postgresql13JitPackages.timescaledb
postgresql13JitPackages.timescaledb-apache
postgresql13Packages.timescaledb
postgresql13Packages.timescaledb-apache

16 packages built:

postgresql14JitPackages.timescaledb
postgresql14JitPackages.timescaledb-apache
postgresql14Packages.timescaledb
postgresql14Packages.timescaledb-apache
postgresql15JitPackages.timescaledb
postgresql15JitPackages.timescaledb-apache
postgresql15Packages.timescaledb
postgresql15Packages.timescaledb-apache
postgresql16JitPackages.timescaledb
postgresql16JitPackages.timescaledb-apache
postgresql16Packages.timescaledb
postgresql16Packages.timescaledb-apache
postgresql17JitPackages.timescaledb
postgresql17JitPackages.timescaledb-apache
postgresql17Packages.timescaledb
postgresql17Packages.timescaledb-apache

wolfgangwalther · 2024-11-19T20:43:05Z

There is now also an update to timescaledb_toolkit available, which adds support for PG17. I suggest you bump that here, too.

Did you have a look at that, too?

Without bumping timescaledb_toolkit we can't test nixosTests.postgresql.timescaledb, I think.

kirillrdy · 2024-11-19T20:45:51Z

There is now also an update to timescaledb_toolkit available, which adds support for PG17. I suggest you bump that here, too.

Did you have a look at that, too?

Without bumping timescaledb_toolkit we can't test nixosTests.postgresql.timescaledb, I think.

I can have a look into timescaledb_toolkit, nixosTests.postgresql.timescaledb ~~builds~~, but master is still on 16.4

EDIT: i was thinking of different attribute

philon123 · 2024-11-19T23:23:31Z

@kirillrdy you're awesome, thanks! Can I help with this somehow? I could maybe confirm it working on x86_64 with a real world use case. Not sure if I can contribute to the actual PR though.

Would it be fine to update to the newest version, v2.17.2?

Any idea if this will make NixOS 24.11?

kirillrdy · 2024-11-19T23:35:55Z

@kirillrdy you're awesome, thanks! Can I help with this somehow? I could maybe confirm it working on x86_64 with a real world use case. Not sure if I can contribute to the actual PR though.

Would it be fine to update to the newest version, v2.17.2?

Any idea if this will make NixOS 24.11?

any testing is much appreciated, I only looked at whats in nixosTests.timescaledb

yes I will bump to v2.17.2

no, this will not make to NixOS 24.11 due to breaking changes, but it doesn't mean it can not be installed on nixos 24.11

Release notes: https://github.com/timescale/timescaledb-toolkit/releases/tag/1.19.0

wolfgangwalther · 2024-11-20T18:20:52Z

postgresql17Packages.timescaledb_toolkit doesn't build for me with this PR:

       > error: unexpected argument '--pg17' found
       >
       >   tip: a similar argument exists: '--pg16'

kirillrdy · 2024-11-20T19:04:23Z

postgresql17Packages.timescaledb_toolkit doesn't build for me with this PR:
       > error: unexpected argument '--pg17' found
       >
       >   tip: a similar argument exists: '--pg16'

yes, looks like we need to bump cargo-pgrx too

Ma27

Ah right, forgot to check the v17 variant of the toolkit. Good thing I got distracted from merging I guess ;-)

Ma27 · 2024-11-20T19:49:57Z

pkgs/development/tools/rust/cargo-pgrx/default.nix

@@ -77,4 +77,11 @@ in
    hash = "sha256-0m9oaqjU42RYyttkTihADDrRMjr2WoK/8sInZALeHws=";
    cargoHash = "sha256-9XTIcpoCnROP63ZTDgMMMmj0kPggiTazKlKQfCgXKzk=";
  };
+
+  cargo-pgrx_0_12_6 = generic {


Can't we bump the alpha version above?

This breaks vector-rs I'll have a look into that

Ah, bummer.
Nvm, you don't have to fix it up in this PR.

I also wonder what the removal policy for those is. cargo-pgrx_0_10_2 is now unused in nixpkgs, because timescaledb_toolkit was the last user. Should we remove it?

Furthermore.. cargo-pgrx is very specific to PostgreSQL and our package set, I wonder whether we should take responsibility for this with the @NixOS/postgres team as well? We could either just add to the OWNERS file directly - or move cargo-pgrx into the postgresql directory. Imho, that would be a much more specific location than tools/rust/....

Certainly out of scope here, just thinking about it while I build nixosTests.postgresql.timescaledb ;)

Should we remove it?

Go for it.
I wouldn't do it on stable, but that's not the case here.

I wonder whether we should take responsibility for this with the @NixOS/postgres team as well?

Sounds good. Do you want to file a PR for that?

Sounds good. Do you want to file a PR for that?

Yeah, I can do that.

wolfgangwalther

Result of nixpkgs-review pr 348223 run on x86_64-linux 1

4 packages marked as broken and skipped:

postgresql13JitPackages.timescaledb
postgresql13JitPackages.timescaledb-apache
postgresql13Packages.timescaledb
postgresql13Packages.timescaledb-apache

1 package blacklisted:

nixos-install-tools

27 packages built:

cargo-pgrx_0_12_6
postgresql13JitPackages.timescaledb_toolkit
postgresql13Packages.timescaledb_toolkit
postgresql14JitPackages.timescaledb
postgresql14JitPackages.timescaledb-apache
postgresql14JitPackages.timescaledb_toolkit
postgresql14Packages.timescaledb
postgresql14Packages.timescaledb-apache
postgresql14Packages.timescaledb_toolkit
postgresql15JitPackages.timescaledb
postgresql15JitPackages.timescaledb-apache
postgresql15JitPackages.timescaledb_toolkit
postgresql15Packages.timescaledb
postgresql15Packages.timescaledb-apache
postgresql15Packages.timescaledb_toolkit
postgresql16JitPackages.timescaledb
postgresql16JitPackages.timescaledb-apache
postgresql16JitPackages.timescaledb_toolkit
postgresql16Packages.timescaledb
postgresql16Packages.timescaledb-apache
postgresql16Packages.timescaledb_toolkit
postgresql17JitPackages.timescaledb
postgresql17JitPackages.timescaledb-apache
postgresql17JitPackages.timescaledb_toolkit
postgresql17Packages.timescaledb
postgresql17Packages.timescaledb-apache
postgresql17Packages.timescaledb_toolkit

nixosTests.postgresql.timescaledb also built fine for all versions.

wolfgangwalther · 2024-11-21T07:26:52Z

Hm, seems like the update for cargo-pgrx broke on darwin:

run pkg_config fail: Could not run `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags openssl`
  The pkg-config command could not be found.

github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 13, 2024

kirillrdy force-pushed the timescale-update branch 2 times, most recently from 60a02dc to 2f0c29c Compare October 13, 2024 19:41

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Oct 13, 2024

kirillrdy force-pushed the timescale-update branch from 3a0d13f to 3573d24 Compare October 16, 2024 19:08

github-actions bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 16, 2024

kirillrdy marked this pull request as ready for review October 17, 2024 08:11

nix-owners bot requested a review from thoughtpolice October 17, 2024 08:12

kirillrdy force-pushed the timescale-update branch from 3573d24 to 8f6d226 Compare October 17, 2024 08:15

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024

kirillrdy force-pushed the timescale-update branch from 8f6d226 to 3f9a40d Compare November 2, 2024 21:13

kirillrdy changed the title ~~postgresqlPackages.timescaledb: 2.14.2 -> 2.17.0; adopt, nixfmt~~ postgresqlPackages.timescaledb: 2.14.2 -> 2.17.1; adopt, nixfmt Nov 2, 2024

kirillrdy requested a review from wolfgangwalther November 2, 2024 21:19

wolfgangwalther requested changes Nov 2, 2024

View reviewed changes

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 3, 2024

kirillrdy force-pushed the timescale-update branch from a4b95c7 to 9b3bb55 Compare November 6, 2024 09:40

kirillrdy marked this pull request as draft November 6, 2024 09:41

nix-owners bot requested a review from Ma27 November 6, 2024 09:41

wolfgangwalther mentioned this pull request Nov 19, 2024

postgresql_17: init at 17.0 #351253

Merged

13 tasks

postgresqlPackages.timescaledb: add kirillrdy to maintainers

4099ca5

kirillrdy force-pushed the timescale-update branch from 9b3bb55 to 7f5e260 Compare November 19, 2024 20:03

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 19, 2024

kirillrdy marked this pull request as ready for review November 19, 2024 20:04

kirillrdy requested a review from wolfgangwalther November 19, 2024 20:08

wolfgangwalther requested changes Nov 19, 2024

View reviewed changes

kirillrdy force-pushed the timescale-update branch from 7f5e260 to 7e13f6f Compare November 19, 2024 20:27

kirillrdy added 4 commits November 20, 2024 17:23

postgresqlPackages.timescaledb: nixfmt

993b24e

nixos/doc/rl-2505: mention timescaledb

1f2ee29

postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0

c273eb2

Release notes: https://github.com/timescale/timescaledb-toolkit/releases/tag/1.19.0

kirillrdy force-pushed the timescale-update branch from 7e13f6f to c273eb2 Compare November 20, 2024 06:24

kirillrdy changed the title ~~postgresqlPackages.timescaledb: 2.14.2 -> 2.17.1; adopt, nixfmt~~ postgresqlPackages.timescaledb: 2.14.2 -> 2.17.2; adopt, nixfmt; postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0 Nov 20, 2024

Ma27 approved these changes Nov 20, 2024

View reviewed changes

kirillrdy added 2 commits November 21, 2024 06:32

cargo-pgrx_0_12_6: init at 0_12_6

07ba29f

postgresqlPackages.timescaledb_toolkit: switch to cargo-pgrx_0_12_6

7baa9da

Ma27 reviewed Nov 20, 2024

View reviewed changes

wolfgangwalther approved these changes Nov 20, 2024

View reviewed changes

Ma27 merged commit f10fc70 into NixOS:master Nov 20, 2024
17 of 18 checks passed

wolfgangwalther mentioned this pull request Nov 20, 2024

cargo-pgrx: drop obsolete versions #357670

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

postgresqlPackages.timescaledb: 2.14.2 -> 2.17.2; adopt, nixfmt; postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0 #348223

postgresqlPackages.timescaledb: 2.14.2 -> 2.17.2; adopt, nixfmt; postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0 #348223

kirillrdy commented Oct 13, 2024 •

edited

Loading

wolfgangwalther left a comment

wolfgangwalther Nov 2, 2024

kirillrdy Nov 19, 2024

wolfgangwalther Nov 2, 2024

kirillrdy Nov 19, 2024

wolfgangwalther commented Nov 2, 2024

kirillrdy commented Nov 6, 2024

wolfgangwalther commented Nov 16, 2024

wolfgangwalther commented Nov 16, 2024

kirillrdy commented Nov 19, 2024

wolfgangwalther left a comment

wolfgangwalther Nov 19, 2024

wolfgangwalther commented Nov 19, 2024

wolfgangwalther commented Nov 19, 2024

kirillrdy commented Nov 19, 2024 •

edited

Loading

philon123 commented Nov 19, 2024

kirillrdy commented Nov 19, 2024

wolfgangwalther commented Nov 20, 2024 •

edited

Loading

kirillrdy commented Nov 20, 2024

Ma27 left a comment

Ma27 Nov 20, 2024

kirillrdy Nov 20, 2024

Ma27 Nov 20, 2024

wolfgangwalther Nov 20, 2024

Ma27 Nov 20, 2024

wolfgangwalther Nov 20, 2024

wolfgangwalther left a comment

wolfgangwalther commented Nov 21, 2024

postgresqlPackages.timescaledb: 2.14.2 -> 2.17.2; adopt, nixfmt; postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0 #348223

postgresqlPackages.timescaledb: 2.14.2 -> 2.17.2; adopt, nixfmt; postgresqlPackages.timescaledb_toolkit: 1.18.0 -> 1.19.0 #348223

Conversation

kirillrdy commented Oct 13, 2024 • edited Loading

Things done

wolfgangwalther left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfgangwalther commented Nov 2, 2024

kirillrdy commented Nov 6, 2024

wolfgangwalther commented Nov 16, 2024

wolfgangwalther commented Nov 16, 2024

kirillrdy commented Nov 19, 2024

nixpkgs-review result

x86_64-linux

wolfgangwalther left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfgangwalther commented Nov 19, 2024

wolfgangwalther commented Nov 19, 2024

kirillrdy commented Nov 19, 2024 • edited Loading

philon123 commented Nov 19, 2024

kirillrdy commented Nov 19, 2024

wolfgangwalther commented Nov 20, 2024 • edited Loading

kirillrdy commented Nov 20, 2024

Ma27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfgangwalther left a comment

Choose a reason for hiding this comment

wolfgangwalther commented Nov 21, 2024

kirillrdy commented Oct 13, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

kirillrdy commented Nov 19, 2024 •

edited

Loading

wolfgangwalther commented Nov 20, 2024 •

edited

Loading