Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

immersed: rename pname of immersed attribute #349195

Merged
merged 1 commit into from
Oct 17, 2024
Merged

immersed: rename pname of immersed attribute #349195

merged 1 commit into from
Oct 17, 2024

Conversation

haruki7049
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@haruki7049 haruki7049 self-assigned this Oct 17, 2024
@ofborg ofborg bot requested a review from Pandapip1 October 17, 2024 04:54
@Atemu Atemu merged commit c8335a1 into NixOS:master Oct 17, 2024
32 of 33 checks passed
@haruki7049 haruki7049 deleted the rename-immersed-pname branch October 17, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@Pandapip1 Pandapip1 Awaiting requested review from Pandapip1

Assignees

@haruki7049 haruki7049

Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

immersed: An difference between immersed's directory name and pname attribute
3 participants
@haruki7049 @Aleksanaa @Atemu