-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging-next] cargo,clippy,rustc,rustfmt: 1.81.0 -> 1.82.0 #349348
Conversation
Built fd.aarch64-darwin, building fd.x86_64-darwin. |
Built fd.x86_64-darwin. |
Can't reproduce the wezterm failure on aarch64-linux, so I can't even verify it wasn't a pre-existing issue. |
For reference: this broke building rustc on riscv64-linux. The problem as discussed in rust-lang/rust#129268 seems to be that the 1.81.0 bootstrap version cannot build the 1.82.0 compiler. |
We currently don't build our distributed RV64 host toolchain using our prior RV64 host toolchain, but rather we cross-build from an x86_64 host. |
Nixpkgs has a strong cross/non-cross distinction, so doing that would be difficult for us. Does bootstrapping 1.82.0 from upstream's 1.82.0 binary work? We should be able to do that for RISC-V native builds if this is important to somebody! |
Yes, that is what I am doing on my machine now. Not important to me to commit it to nixpkgs. I can just wait for 1.83. |
Oh, but this is going to be the Rust release that we stick to for 24.11, hmm… |
I guess it can be fixed at any time by somebody who has the hardware to be able to test it. |
I forgot about that. Going to prepare a PR. |
It's early enough in the cycle that we should be able to get this in without rebuilds.
Please help test Darwin!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.