Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] cargo,clippy,rustc,rustfmt: 1.81.0 -> 1.82.0 #349348

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Oct 17, 2024

It's early enough in the cycle that we should be able to get this in without rebuilds.

  • fd.x86_64-linux
  • firefox.x86_64-linux
  • thunderbird.x86_64-linux
  • fd.aarch64-linux
  • fd.x86_64-darwin
  • fd.aarch64-darwin

Please help test Darwin!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zowoq
Copy link
Contributor

zowoq commented Oct 18, 2024

Built fd.aarch64-darwin, building fd.x86_64-darwin.

@zowoq
Copy link
Contributor

zowoq commented Oct 18, 2024

Built fd.x86_64-darwin.

@alyssais
Copy link
Member Author

Can't reproduce the wezterm failure on aarch64-linux, so I can't even verify it wasn't a pre-existing issue.

@alyssais alyssais merged commit c263e0b into NixOS:staging-next Oct 18, 2024
56 of 57 checks passed
@alyssais alyssais deleted the rust-1.82 branch October 18, 2024 08:13
@skeuchel
Copy link
Contributor

For reference: this broke building rustc on riscv64-linux. The problem as discussed in rust-lang/rust#129268 seems to be that the 1.81.0 bootstrap version cannot build the 1.82.0 compiler.

@workingjubilee
Copy link

workingjubilee commented Oct 22, 2024

We currently don't build our distributed RV64 host toolchain using our prior RV64 host toolchain, but rather we cross-build from an x86_64 host.

@alyssais
Copy link
Member Author

Nixpkgs has a strong cross/non-cross distinction, so doing that would be difficult for us.

Does bootstrapping 1.82.0 from upstream's 1.82.0 binary work? We should be able to do that for RISC-V native builds if this is important to somebody!

@skeuchel
Copy link
Contributor

Nixpkgs has a strong cross/non-cross distinction, so doing that would be difficult for us.

Does bootstrapping 1.82.0 from upstream's 1.82.0 binary work? We should be able to do that for RISC-V native builds if this is important to somebody!

Yes, that is what I am doing on my machine now. Not important to me to commit it to nixpkgs. I can just wait for 1.83.

@alyssais
Copy link
Member Author

Oh, but this is going to be the Rust release that we stick to for 24.11, hmm…

@alyssais
Copy link
Member Author

I guess it can be fixed at any time by somebody who has the hardware to be able to test it.

@skeuchel
Copy link
Contributor

Oh, but this is going to be the Rust release that we stick to for 24.11, hmm…

I forgot about that. Going to prepare a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants