Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stravaweblib: init at 0.0.8 #350041

Merged
merged 1 commit into from
Oct 28, 2024
Merged

stravaweblib: init at 0.0.8 #350041

merged 1 commit into from
Oct 28, 2024

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Oct 20, 2024

stravaweblib is a Python package extending the Strava v3 API using web scraping.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4737

@stv0g
Copy link
Contributor Author

stv0g commented Oct 26, 2024

Hey @natsukium, do you maybe have some time to have a look at this PR?

@stv0g stv0g marked this pull request as draft October 26, 2024 15:25
@stv0g stv0g force-pushed the init-stravaweblib branch from 1bc0b6c to 8418f38 Compare October 27, 2024 09:27
@stv0g stv0g marked this pull request as ready for review October 27, 2024 09:27
@stv0g stv0g requested review from sikmir and doronbehar October 27, 2024 09:27
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics mostly. Looks good overall.

@stv0g stv0g force-pushed the init-stravaweblib branch from 8418f38 to 57b4a24 Compare October 27, 2024 09:37
@stv0g
Copy link
Contributor Author

stv0g commented Oct 27, 2024

Thanks for the quick review 👍🏻

@stv0g stv0g requested a review from doronbehar October 27, 2024 11:20
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 27, 2024
@stv0g stv0g force-pushed the init-stravaweblib branch from 57b4a24 to f12a377 Compare October 27, 2024 12:32
@stv0g stv0g requested a review from doronbehar October 27, 2024 12:32
@doronbehar doronbehar merged commit 921f518 into NixOS:master Oct 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants