-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stravaweblib: init at 0.0.8 #350041
stravaweblib: init at 0.0.8 #350041
Conversation
40a2e47
to
1bc0b6c
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4737 |
Hey @natsukium, do you maybe have some time to have a look at this PR? |
1bc0b6c
to
8418f38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetics mostly. Looks good overall.
8418f38
to
57b4a24
Compare
Thanks for the quick review 👍🏻 |
57b4a24
to
f12a377
Compare
stravaweblib is a Python package extending the Strava v3 API using web scraping.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.