-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kanata-with-cmd: 1.7.0-prerelease-1 -> 1.7.0 #351675
Conversation
1.7.0 includes breaking changes. Do not merge this PR when breaking changes are not allowed, see #339153. |
@jian-lin do you know if there are breaking changes between the pre-release version and the release? We may have already brought in the breaking changes, so this update can actually go through. |
Unfortunately, according to upstream release notes, the current version in Nixpkgs does not have those breaking changes. |
Yeah. The breaking changes were in the release notes for the second pre-release version, but not the first. Without digging into the commits themselves, we will have to assume the were introduced between the releases. |
The specific commit is jtroo/kanata@4e53544. If there are strong benefits of including this update, IMHO, we can merge this. |
3120f80
to
90b343e
Compare
@wegank Thanks for taking care of this PR. May I ask why this PR is merged prematurely given that no approvals are given by its two active maintainers? I do not give my approval because I have not tested it yet. I plan to test it after the branch-off. I also plan to add release notes about the breaking changes contained in this bump. |
Sorry, I misunderstood the conversation, feel free to revert. (This PR has been merged to staging, i.e., it won't be included in NixOS 24.11.) |
I am aware of that. I am wondering which will make it into the unstable branch sooner, merging it into master after the branch-off or merging it into staging now. I do not think it needs a revert. I'll test it and add release notes in a following PR. |
Definitely the first one. @RossComputerGuy do you think it's a good idea to have a |
Hmm, a revert is probably better then. |
No, it should be after branch off when we set up the branches for 25.05. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for kanata-with-cmd is: Tool to improve keyboard comfort and usability with advanced customization
meta.homepage for kanata-with-cmd is: https://github.com/jtroo/kanata
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review
resultGenerated using
nixpkgs-review
.Command:
nixpkgs-review
x86_64-linux
✅ 2 packages built:
Maintainer pings
cc @bmanuel @jian-lin for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*
, you can comment@NixOS/nixpkgs-merge-bot merge
to automatically merge this update using thenixpkgs-merge-bot
.Add a 👍 reaction to pull requests you find important.