Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kanata-with-cmd: 1.7.0-prerelease-1 -> 1.7.0 #351675

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for kanata-with-cmd is: Tool to improve keyboard comfort and usability with advanced customization

meta.homepage for kanata-with-cmd is: https://github.com/jtroo/kanata

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.7.0 with grep in /nix/store/3sx1qqbaz00sc9bwcis70xapd8lrimy7-kanata-1.7.0
  • found 1.7.0 in filename of file in /nix/store/3sx1qqbaz00sc9bwcis70xapd8lrimy7-kanata-1.7.0

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

kanata
kanata-with-cmd
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/3sx1qqbaz00sc9bwcis70xapd8lrimy7-kanata-1.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A kanata-with-cmd https://github.com/r-ryantm/nixpkgs/archive/3120f808481d3ffd4b91b156ab54ddbfd968f782.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/3120f808481d3ffd4b91b156ab54ddbfd968f782#kanata-with-cmd

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/3sx1qqbaz00sc9bwcis70xapd8lrimy7-kanata-1.7.0
ls -la /nix/store/3sx1qqbaz00sc9bwcis70xapd8lrimy7-kanata-1.7.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 2 packages built:
  • kanata
  • kanata-with-cmd

Maintainer pings

cc @bmanuel @jian-lin for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@jian-lin
Copy link
Contributor

1.7.0 includes breaking changes. Do not merge this PR when breaking changes are not allowed, see #339153.

@bmanuel
Copy link
Contributor

bmanuel commented Oct 28, 2024

@jian-lin do you know if there are breaking changes between the pre-release version and the release? We may have already brought in the breaking changes, so this update can actually go through.

@jian-lin
Copy link
Contributor

jian-lin commented Oct 28, 2024

Unfortunately, according to upstream release notes, the current version in Nixpkgs does not have those breaking changes.

@bmanuel
Copy link
Contributor

bmanuel commented Oct 28, 2024

Yeah. The breaking changes were in the release notes for the second pre-release version, but not the first. Without digging into the commits themselves, we will have to assume the were introduced between the releases.

@jian-lin
Copy link
Contributor

The specific commit is jtroo/kanata@4e53544.

If there are strong benefits of including this update, IMHO, we can merge this.

@wegank wegank added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 2, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@wegank wegank marked this pull request as draft November 10, 2024 01:27
@wegank wegank changed the base branch from master to staging November 10, 2024 01:27
@wegank wegank force-pushed the auto-update/kanata-with-cmd branch from 3120f80 to 90b343e Compare November 10, 2024 01:28
@wegank wegank marked this pull request as ready for review November 10, 2024 01:28
@wegank wegank removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@wegank wegank merged commit 54b3f32 into NixOS:staging Nov 10, 2024
12 of 13 checks passed
@jian-lin
Copy link
Contributor

@wegank Thanks for taking care of this PR. May I ask why this PR is merged prematurely given that no approvals are given by its two active maintainers?

I do not give my approval because I have not tested it yet. I plan to test it after the branch-off. I also plan to add release notes about the breaking changes contained in this bump.

@wegank
Copy link
Member

wegank commented Nov 10, 2024

Sorry, I misunderstood the conversation, feel free to revert.

(This PR has been merged to staging, i.e., it won't be included in NixOS 24.11.)

@jian-lin
Copy link
Contributor

jian-lin commented Nov 10, 2024

(This PR has been merged to staging, i.e., it won't be included in NixOS 24.11.)

I am aware of that. I am wondering which will make it into the unstable branch sooner, merging it into master after the branch-off or merging it into staging now.

I do not think it needs a revert. I'll test it and add release notes in a following PR.

@wegank
Copy link
Member

wegank commented Nov 10, 2024

Definitely the first one.

@RossComputerGuy do you think it's a good idea to have a rl-2505.section.md before branch-off?

@jian-lin
Copy link
Contributor

Definitely the first one.

Hmm, a revert is probably better then.

@RossComputerGuy
Copy link
Member

do you think it's a good idea to have a rl-2505.section.md before branch-off?

No, it should be after branch off when we set up the branches for 25.05.

@r-ryantm r-ryantm deleted the auto-update/kanata-with-cmd branch November 10, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants