-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcamera: re-sign IPA modules after fixup #353336
libcamera: re-sign IPA modules after fixup #353336
Conversation
it's a heavy rebuild count but this is a pretty significant bugfix for desktop users, so targeting master is warranted IMO. current experience for me on master is that pipewire/libcamera based applications (e.g. gnome cherry-picked this PR and re-deployed my system: everything built fine, cameras are working again. |
Currently the behavior (at least on my device) is that libcamera segfaults after failing to find the IPA proxy so if it already started talking to the camera it makes sense that it'd leave it in a broken state. On my device when libcamera segfaults it also brings down wireplumber and pipewire with it, so if I don't blacklist the kernel module for the camera driver I don't even get any sound! I'm looking forward to getting this merged so I don't have to recompile webkitgtk on my workstation anymore :) |
(cherry picked from commit b9274aa)
Successfully created backport PR for |
Git push to origin failed for staging-24.11 with exitcode 1 |
Given how long the bug's been (reportedly) present (e.g. it was there on the first release of 24.05), I really doubt that it's become so urgent now. Still, the rebuild isn't huge and |
Re-introduced the
postFixup
IPA module re-signing step that was erroneously removed in fb0ddd9 to address #351842.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.