Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatsu: 0.2.2 -> 0.3.0 #354408

Merged
merged 1 commit into from
Nov 12, 2024
Merged

hatsu: 0.2.2 -> 0.3.0 #354408

merged 1 commit into from
Nov 12, 2024

Conversation

kwaa
Copy link
Member

@kwaa kwaa commented Nov 8, 2024

https://github.com/importantimport/hatsu/releases/tag/v0.3.0

Tested basic functionality of binary files via:

nix run .#hatsu -- --version
HATSU_PRIMARY_ACCOUNT="kwaa.dev" HATSU_DOMAIN="hatsu.local" nix run .#hatsu

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kwaa kwaa added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Nov 8, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2024
@kirillrdy
Copy link
Member

@kwaa can you also add link to release notes to commit

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

@kwaa
Copy link
Member Author

kwaa commented Nov 8, 2024

@kwaa can you also add link to release notes to commit

done

@kwaa
Copy link
Member Author

kwaa commented Nov 10, 2024

@SuperSandro2000 Can you re-review it? thx

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2024
@kwaa
Copy link
Member Author

kwaa commented Nov 12, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354408


x86_64-linux

✅ 1 package built:
  • hatsu

@kirillrdy kirillrdy merged commit 980c70c into NixOS:master Nov 12, 2024
33 of 34 checks passed
@kirillrdy
Copy link
Member

@kwaa thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants