Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

froide: init at 0-unstable-2024-11-22 #355835

Merged
merged 2 commits into from
Dec 3, 2024
Merged

froide: init at 0-unstable-2024-11-22 #355835

merged 2 commits into from
Dec 3, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented Nov 14, 2024 •
edited
Loading

Adding web app froide, a portal for creating and following freedom of information act requests. Used by FragDenStaat project.

Adding it only as Python module as such it can also be used by other projects - in my use case #349750

Related:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 14, 2024
@onny onny mentioned this pull request Nov 14, 2024
Draft
20 tasks
pluiedev
pluiedev suggested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to clarify which country/region this app is for? Also please run nixfmt on your changes (except for large files like all-packages.nix, python-modules.nix, etc), and reorder commits so that froide's dependencies are added before froide itself

nixos/modules/services/web-apps/froide.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/froide.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/froide.nix Outdated Show resolved Hide resolved
nixos/tests/froide.nix Outdated Show resolved Hide resolved
pkgs/by-name/fr/froide/package.nix Show resolved Hide resolved
pkgs/by-name/fr/froide/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fr/froide/package.nix Show resolved Hide resolved
pkgs/development/python-modules/django-fsm/default.nix Outdated Show resolved Hide resolved
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Nov 15, 2024
@onny onny force-pushed the froide branch 2 times, most recently from 770a98b to c63c317 Compare November 15, 2024 17:53
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 16, 2024
@onny onny mentioned this pull request Nov 17, 2024
Closed
@onny onny changed the title froide: init at 0-unstable-2024-07-15; nixos/froide: init froide: init at 0-unstable-2024-11-22; nixos/froide: init Nov 24, 2024
@onny onny force-pushed the froide branch 5 times, most recently from 77619db to 96bb1f3 Compare November 24, 2024 15:23
@onny onny changed the title froide: init at 0-unstable-2024-11-22; nixos/froide: init python3Packages.froide: init at 0-unstable-2024-11-22 Nov 25, 2024
@github-actions github-actions bot removed 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 25, 2024
@github-actions github-actions bot removed the 8.has: module (update) This PR changes an existing module in `nixos/` label Nov 25, 2024
@onny onny marked this pull request as ready for review November 25, 2024 17:08
@onny onny requested a review from pluiedev November 25, 2024 17:08
@nix-owners nix-owners bot requested a review from natsukium November 25, 2024 17:18
@onny onny force-pushed the froide branch 2 times, most recently from e64af64 to 8e87442 Compare November 25, 2024 18:00
@onny onny changed the title python3Packages.froide: init at 0-unstable-2024-11-22 froide: init at 0-unstable-2024-11-22 Nov 25, 2024
@onny onny requested a review from pluiedev November 25, 2024 18:01
@onny
Copy link
Contributor Author

onny commented Nov 25, 2024

Thank you @pluiedev fixed it :)

pluiedev
pluiedev approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'm not a Python domain expert. Would want to get feedback from them first

@onny onny requested a review from SuperSandro2000 November 26, 2024 07:58
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Nov 26, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@onny onny requested review from e1mo, wegank and Atemu November 27, 2024 11:12
@onny onny merged commit ff04c2d into NixOS:master Dec 3, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluiedev pluiedev pluiedev approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@e1mo e1mo Awaiting requested review from e1mo

@wegank wegank Awaiting requested review from wegank

@Atemu Atemu Awaiting requested review from Atemu

Assignees
No one assigned
Labels
6.topic: python 8.has: module (new) This PR adds a module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person ofborg-internal-error Ofborg encountered an error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onny @pluiedev @wegank @h7x4