Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-runner: 2.320.0 -> 2.321.0 #356300

Merged
merged 1 commit into from
Nov 19, 2024
Merged

github-runner: 2.320.0 -> 2.321.0 #356300

merged 1 commit into from
Nov 19, 2024

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Nov 15, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@YorikSar YorikSar force-pushed the update-github-runner branch from 23b17df to 19ab04a Compare November 15, 2024 22:52
@YorikSar
Copy link
Contributor Author

YorikSar commented Nov 15, 2024 •
edited
Loading

@NixOS/nix-formatting Why did nixfmt check forced me to make this change: https://github.com/NixOS/nixpkgs/compare/23b17df5a709373bd3cfc297994ea54d06506707..19ab04a20aade9f1ae21726c8f4304dff2cc47d5 even though I didn't touch those lines or anything around them? Did some formatting style change since last change to this file? If it did, why is it considered formatted before my commit?

Sorry for the noise, I was wrong, I removed part of this assignment, that's why it needed to be reformatted. Nevermind.

drupol
drupol requested changes Nov 17, 2024
View reviewed changes
pkgs/by-name/gi/github-runner/package.nix Outdated Show resolved Hide resolved
@YorikSar
github-runner: 2.320.0 -> 2.321.0
db1d5cf 
* remove mentions of Node.js 16 which is not supported anymore
  see actions/runner#3503
* switch to .Net SDK 8
  see actions/runner#3500
* fix source path discovery in deterministic build: runtime assumes that
  the root of the project is `/_`, replace it with actual `/build/src`
  so that tests can find their data.
@YorikSar YorikSar force-pushed the update-github-runner branch from 19ab04a to db1d5cf Compare November 17, 2024 23:22
@YorikSar YorikSar requested a review from drupol November 17, 2024 23:23
@kfollesdal
Copy link
Contributor

Result of nixpkgs-review pr 356300 run on x86_64-linux 1

1 package built:
  • github-runner

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 19, 2024
@tomberek tomberek merged commit 13d6e15 into NixOS:master Nov 19, 2024
29 of 30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-356300-to-release-24.05 origin/release-24.05
cd .worktree/backport-356300-to-release-24.05
git switch --create backport-356300-to-release-24.05
git cherry-pick -x db1d5cf76b0bf02854eb950abe3dc0642642162e

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-356300-to-release-24.05 origin/release-24.05
cd .worktree/backport-356300-to-release-24.05
git switch --create backport-356300-to-release-24.05
git cherry-pick -x db1d5cf76b0bf02854eb950abe3dc0642642162e

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.11 with exitcode 1

@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
1 task
@YorikSar YorikSar deleted the update-github-runner branch November 19, 2024 21:14
@YorikSar YorikSar mentioned this pull request Nov 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@kfollesdal kfollesdal kfollesdal approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@zimbatm zimbatm Awaiting requested review from zimbatm

@veehaitch veehaitch Awaiting requested review from veehaitch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YorikSar @kfollesdal @drupol @tomberek @wegank