nixos/lxc/container: allow useDhcp with LXC containers #358519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
17 tasks
|
Wouldn't it be better to add a separate |
ofborg
bot
added
10.rebuild-darwin: 0
What makes that better? |
|
Previously the default behavior was to match both physical and virtual ethernet interfaces. I think we should keep it instead of only enabling for veth. |
|
In what scenario would the physical unit match any devices in an LXC container? |
|
Maybe when an interface is passed through (using |
adamcstephens
force-pushed
the
push-zpqwsrknnxrz
branch
from
7597c76 to
964bdaa
Compare
|
Sigh. This is now here. #358806 I suspect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#347283 changed the default to exclude non-physical network Kind, but that unfortunately also includes
vethwhich LXC uses for its network interfaces. Re-enable that functionality so users can use networkd with useDHCP.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.