-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbitcoin{,-client,-explorer,-network,-protocol}: drop; boost175: drop #358867
Conversation
These are the last packages in the tree that depend on Boost 1.75. There hasn’t been a release since 2023; upstream have stated in <libbitcoin/libbitcoin-system#1234> that they do not plan to maintain the current version, and are currently working on a backwards‐incompatible major update. Nothing in the tree uses these libraries. The only other software distributions on Repology packaging them are YACP and the AUR, neither of which has had an update since 2019. They were removed from Ubuntu after 16.04, and have more recently been removed from [SlackBuilds.org] and [Homebrew] with the same reasoning that they’re keeping Boost 1.75 around unnecessarily and no packaged software wants them. [SlackBuilds.org]: SlackBuildsOrg/slackbuilds@17c7d0e [Homebrew]: Homebrew/homebrew-core#157427 Since these packages are also unmaintained in Nixpkgs, let’s just drop them and if anyone wants to package the 4.x version when it’s out they can re‐add it.
Obsolete version with no remaining users in the tree. Already removed by other distributions.
this is a breaking change and shouldn't be backported. |
The outcome of a discussion in the Release Management room a while ago was that dropping packages up until release is fine, especially if they are unmaintained/EOL/at risk of becoming vulnerable during the release cycle. This library had a CVE last year when the 3.x series was still being maintained upstream so if that happened again it’s likely 24.11 would remain vulnerable without any Nixpkgs maintainer to remediate it. I don’t really care one way or the other if this is backported, though (and maybe the Boost removal makes it impactful enough that we shouldn’t, although AFAICT everyone else has long moved off this version). |
I see -- backport away. |
Successfully created backport PR for |
These are the last packages in the tree that depend on Boost 1.75. There hasn’t been a release since 2023; upstream have stated in libbitcoin/libbitcoin-system#1234 that they do not plan to maintain the current version, and are currently working on a backwards‐incompatible major update.
Nothing in the tree uses these libraries. The only other software distributions on Repology packaging them are YACP and the AUR, neither of which has had an update since 2019. They were removed from Ubuntu after 16.04, and have more recently been removed from SlackBuilds.org and Homebrew with the same reasoning that they’re keeping Boost 1.75 around unnecessarily and no packaged software wants them.
Since these packages are also unmaintained in Nixpkgs, let’s just drop them and if anyone wants to package the 4.x version when it’s out they can re‐add it.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.