Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbitcoin{,-client,-explorer,-network,-protocol}: drop; boost175: drop #358867

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Nov 25, 2024

These are the last packages in the tree that depend on Boost 1.75. There hasn’t been a release since 2023; upstream have stated in libbitcoin/libbitcoin-system#1234 that they do not plan to maintain the current version, and are currently working on a backwards‐incompatible major update.

Nothing in the tree uses these libraries. The only other software distributions on Repology packaging them are YACP and the AUR, neither of which has had an update since 2019. They were removed from Ubuntu after 16.04, and have more recently been removed from SlackBuilds.org and Homebrew with the same reasoning that they’re keeping Boost 1.75 around unnecessarily and no packaged software wants them.

Since these packages are also unmaintained in Nixpkgs, let’s just drop them and if anyone wants to package the 4.x version when it’s out they can re‐add it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

These are the last packages in the tree that depend on Boost
1.75. There hasn’t been a release since 2023; upstream have stated
in <libbitcoin/libbitcoin-system#1234> that
they do not plan to maintain the current version, and are currently
working on a backwards‐incompatible major update.

Nothing in the tree uses these libraries. The only other software
distributions on Repology packaging them are YACP and the AUR, neither
of which has had an update since 2019. They were removed from Ubuntu
after 16.04, and have more recently been removed from [SlackBuilds.org]
and [Homebrew] with the same reasoning that they’re keeping Boost
1.75 around unnecessarily and no packaged software wants them.

[SlackBuilds.org]: SlackBuildsOrg/slackbuilds@17c7d0e
[Homebrew]: Homebrew/homebrew-core#157427

Since these packages are also unmaintained in Nixpkgs, let’s just
drop them and if anyone wants to package the 4.x version when it’s
out they can re‐add it.
Obsolete version with no remaining users in the tree. Already removed
by other distributions.
@emilazy emilazy added the backport release-24.11 Backport PR automatically label Nov 25, 2024
@paparodeo
Copy link
Contributor

this is a breaking change and shouldn't be backported.

@emilazy
Copy link
Member Author

emilazy commented Nov 25, 2024

The outcome of a discussion in the Release Management room a while ago was that dropping packages up until release is fine, especially if they are unmaintained/EOL/at risk of becoming vulnerable during the release cycle. This library had a CVE last year when the 3.x series was still being maintained upstream so if that happened again it’s likely 24.11 would remain vulnerable without any Nixpkgs maintainer to remediate it. I don’t really care one way or the other if this is backported, though (and maybe the Boost removal makes it impactful enough that we shouldn’t, although AFAICT everyone else has long moved off this version).

@paparodeo
Copy link
Contributor

The outcome of a discussion in the Release Management room a while ago was that dropping packages up until release is fine, especially if they are unmaintained/EOL/at risk of becoming vulnerable during the release cycle.

I see -- backport away.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 25, 2024
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 25, 2024
@wegank wegank merged commit bdf3bbe into NixOS:master Nov 25, 2024
34 checks passed
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-24.11 Backport PR automatically
Projects
Development

Successfully merging this pull request may close these issues.

4 participants