Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nerd-fonts: move release note to 25.05 #359225

Merged
merged 1 commit into from
Nov 27, 2024
Merged

nerd-fonts: move release note to 25.05 #359225

merged 1 commit into from
Nov 27, 2024

Conversation

Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented Nov 26, 2024 •
edited
Loading

#354543

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 26, 2024
@Aleksanaa Aleksanaa requested a review from doronbehar November 26, 2024 11:52
@doronbehar
Copy link
Contributor

Oh it was released already? I didn't see a backport-25.05 GH label so I thought I catched the train in the last minute.. Anyway, that also means that the backport #359222 shouldn't be made? It is a backwards incompatibility in terms of top level attributes..

@Aleksanaa
Copy link
Member Author

It's not released, but the change is a backward incompatibility

@doronbehar
Copy link
Contributor

So it is not released yet, but still we don't want to insert any backwards incompatible changes to it? Why?

@Aleksanaa
Copy link
Member Author

See #339153 https://github.com/NixOS/nixpkgs/tree/master/maintainers#breaking-changes

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@Aleksanaa Aleksanaa merged commit 2342b52 into NixOS:master Nov 27, 2024
18 of 19 checks passed
@Aleksanaa Aleksanaa deleted the nerd-fonts branch November 27, 2024 02:08
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Nov 27, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
65f1bc5 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Nov 28, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
5f5dc65 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Nov 28, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
6f0ca2c 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Nov 29, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
097e248 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Nov 29, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
1e6cd39 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Nov 30, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
4ec0bcf 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Dec 1, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
5145ea2 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Dec 1, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
be7e9ed 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Dec 2, 2024
@eadwu
Revert "nerd-fonts: move release note to 25.05 (NixOS#359225)"
bb8a2f6 
This reverts commit 2342b52, reversing
changes made to 36f0b3a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@nbdd0121 nbdd0121 nbdd0121 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aleksanaa @doronbehar @nbdd0121 @wegank