make-disk-image: Allow passing of image baseName #359326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently alsways "nixos", which leads to various schemes of renaming the resulting files in virtualisation/*-image.nix files as well as further downstream, outside of nixpkgs.
github-actions
bot
added
the
6.topic: nixos
This was referenced Nov 26, 2024
arianvp
approved these changes
Nov 26, 2024
zimbatm
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently always "nixos", which leads to various schemes of renaming the resulting files in virtualisation/*-image.nix files as well as further downstream, outside of nixpkgs.
This parameter should be a no-op if unused and allows users using the right baseName to begin with.
It was split off #347275 in order to upstream that one in smaller chunks, easier to review, test and (hopefully not) revert.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.