lomiri.lomiri-url-dispatcher: Fix libexec binary location in services #359687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SystemD service files hardcode the location of the libexec binaries before
moveToOutput
moves them around, so the paths end up broken. Work around this by overridingCMAKE_INSTALL_LIBEXECDIR
at configure time, somoveToOutput
isn't necessary anymore.It currently doesn't break the tests, so maybe it should be tested that LUD launches & can handle dispatch requests? But I don't expect this to break again - it broke because of the new
lib
output, which was added to reduce closure size of non-Lomiri environments when using ayatana indicators. Maybe a hook to check installed systemd services for validExecStart
paths in general would be neat, dunno if that would break something though.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.