Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/eval: Also count added packages as rebuilds #361206

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

infinisil
Copy link
Member

This is also what ofborg does, discovered by @FliegendeWurst after #359704

Things done


This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

This is also what ofborg does
@infinisil infinisil added the backport release-24.11 Backport PR automatically label Dec 2, 2024
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Dec 2, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 2, 2024
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@philiptaron
Copy link
Contributor

Silvan, are you collecting languages you've written load-bearing production code in? 😜

@infinisil
Copy link
Member Author

Haha I guess so! I feel like jq hits a good spot where it's interpreted (so not needing compilation like nixpkgs-vet), not arcane (such as bash), and made for processing (unlike Nix). I'd be happy to merge a rewrite in Nix though, that's definitely more approachable 😄

@philiptaron philiptaron merged commit cc423c2 into NixOS:master Dec 2, 2024
18 of 19 checks passed
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Successfully created backport PR for release-24.11:

@paparodeo
Copy link
Contributor

paparodeo commented Dec 6, 2024

#362028

should have added a darwin rebuild but it did not. (the package is new for darwin as meta.platforms was previously just linux but I changed it to unix).

[edit] ofborg updated the labels but can still see the results of the GHA evaluation counts.
https://github.com/NixOS/nixpkgs/actions/runs/12178480057?pr=362028

but it should look like: https://github.com/paparodeo/nixpkgs/actions/runs/12194693847

@paparodeo
Copy link
Contributor

paparodeo commented Dec 6, 2024

Haha I guess so! I feel like jq hits a good spot where it's interpreted (so not needing compilation like nixpkgs-vet), not arcane (such as bash), and made for processing (unlike Nix). I'd be happy to merge a rewrite in Nix though, that's definitely more approachable 😄

FWIW I did implement this in sql using duckdb (duckdb is handy to do sql things on csv and json files, among other things)
https://github.com/paparodeo/nixpkgs/blob/eval-duckdb/ci/eval/compare.sql
tho not sure if worth pursuing further as while easier for me to deal with not sure if it is for others.

@infinisil
Copy link
Member Author

For future reference: #362844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants