Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

famistudio: .NET 7 -> 8 #361867

Merged
merged 4 commits into from
Dec 5, 2024
Merged

famistudio: .NET 7 -> 8 #361867

merged 4 commits into from
Dec 5, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Dec 4, 2024 •
edited
Loading

Tracking: #326335

Upstream already upgraded to .NET 8 but it's unreleased: BleuBleu/FamiStudio@22f1c4f

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird gepbird mentioned this pull request Dec 4, 2024
Open
17 tasks
@gepbird
Copy link
Contributor Author

gepbird commented Dec 4, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361867

x86_64-linux

✅ 1 package built:
  • famistudio

@gepbird gepbird requested a review from OPNA2608 December 4, 2024 21:01
@gepbird gepbird added the backport release-24.11 Backport PR automatically label Dec 4, 2024
OPNA2608
OPNA2608 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 361867 run on x86_64-darwin 1

1 package built:
  • famistudio

x86_64-linux

✅ 1 package built:
  • famistudio

LGTM, works on x86_64-linux.

@OPNA2608 OPNA2608 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 5, 2024
@OPNA2608 OPNA2608 merged commit 7c0fc9c into NixOS:master Dec 5, 2024
46 of 47 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 5, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 5, 2024
Merged
1 task
@gepbird gepbird deleted the famistudio-dotnet-8 branch December 6, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gepbird @OPNA2608