Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet: fix packages that fail to build with strictDeps #362420

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Dec 6, 2024

This is in preparation for enabling strictDeps by default in buildDotnetModule.

Cc: @NixOS/dotnet

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@corngood
Copy link
Contributor Author

corngood commented Dec 6, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362420


x86_64-linux

✅ 2 packages built:
  • github-runner
  • tagger

@layus
Copy link
Member

layus commented Dec 6, 2024 via email

@GGG-KILLER GGG-KILLER added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 6, 2024
@layus layus merged commit 4a62c98 into NixOS:master Dec 6, 2024
45 of 46 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 6, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants