Fix cross eval issues #362546
Merged
Fix cross eval issues #362546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: haskell
6.topic: k3s
13 tasks
nix-owners
bot
requested review from
maralorn,
mweinelt,
natsukium and
sternenseemann
Artturin
added
the
6.topic: cross-compilation
github-actions
bot
added
10.rebuild-darwin: 0
mweinelt
approved these changes
Dec 6, 2024
philiptaron
approved these changes
Dec 7, 2024
sternenseemann
previously requested changes
Dec 7, 2024
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
from
376de9c to
9245a60
Compare
philiptaron
approved these changes
Dec 7, 2024
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
from
53e61be to
905d1b8
Compare
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
from
905d1b8 to
afb33a2
Compare
philiptaron
approved these changes
Dec 9, 2024
wegank
added
the
12.approvals: 2
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
from
afb33a2 to
7e6ef49
Compare
github-actions
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
wegank
removed
the
12.approvals: 2
https://www.github.com/NixOS/nixpkgs/issues/362272 Fixes ``` $ nix repl --file . --system aarch64-darwin nix-repl> pkgsCross.aarch64-multiplatform.haskellPackages.ghc-lib.env error: … while evaluating attribute 'LOCALE_ARCHIVE' of derivation 'ghc-shell-for-ghc-lib-aarch64-unknown-linux-gnu-9.6.6.20240701-aarch64-unknown-linux-gnu' error: cannot coerce null to a string: null ```
`throw`s are better because they don't abort evaluation when evaluating the whole set. Fixes `error: evaluation aborted with the following error message: 'Unsupported platform: arm64.'` on linux cross from darwin
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
2 times, most recently
from
1c386fd to
8d0daf6
Compare
github-actions
bot
added
8.has: documentation
github-actions
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
Don't fail with a missing attribute error, so the error can be handled.
…cross eval Release eval fails with ``` nix-env failed: trace: evaluation warning: cannot enable SNMP support due to cross-compilation issues with net-snmp-config ```
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
from
8d0daf6 to
eddbb62
Compare
sternenseemann
approved these changes
Dec 12, 2024
|
|
In https://www.github.com/NixOS/nixpkgs/pull/341067 `ofborg-eval-lib-tests` fails because it uses `pkgsHostTarget` of the cross pkgs ```diff diff --git a/pkgs/top-level/impure.nix b/pkgs/top-level/impure.nix index 4d847e280f4b..7f0099b254f0 100644 --- a/pkgs/top-level/impure.nix +++ b/pkgs/top-level/impure.nix @@ -86,4 +86,6 @@ assert args ? system -> !(args ? localSystem); import ./. (builtins.removeAttrs args [ "system" ] // { inherit config overlays localSystem; -}) +} // (if ((localSystem.system or localSystem) == "x86_64-linux" || (localSystem.system or localSystem) == "aarch64-linux") then { + crossSystem = { config = "aarch64-unknown-linux-gnu"; }; + } else {}) ) ```
Dunno if this is correct, there's other `hostPlatform.isDarwin`
conditionals which may be wrong.
Leaving the other conditionals to swift maintainers or people who are
interested in swift cross-compilation
```
$ nix repl --file . --system aarch64-darwin
nix-repl> pkgsCross.aarch64-multiplatform.swift
«derivation /nix/store/kqbaqwdfc9g0yvkq4ffrlqspranprlmy-swift-wrapper-aarch64-unknown-linux-gnu-5.8.drv»
nix-repl> pkgsCross.aarch64-multiplatform.buildPackages.swift
error:
error: expected a string but found null: null
at /home/artturin/nixgits/my-nixpkgs/.worktree/2/pkgs/development/compilers/swift/compiler/default.nix:586:11:
585| #WATCHOS_SIMULATOR
586| }.${targetPlatform.darwinPlatform}}
| ^
587|
```
|
Added comment to release.nix and updated the patch in the commit msg |
Artturin
force-pushed
the
splitfromtestperfofsplice
branch
from
eddbb62 to
276fe40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #341067
Exposed by https://github.com/NixOS/nixpkgs/commit/bd32adb9e8452e96f7dbb5ee0bebd96bab0ea320.patch
https://github.com/NixOS/nixpkgs/commit/6761b8e2ff4861cd5f371ebb2753ec547078221d.patch
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.