Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guile: workaround for libunistring / darwin libiconv #364503

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 12, 2024

guile will fail in the configure phase on darwin due to libunistring not
building with libiconv as libunistring 1.3 rejects darwin's libiconv
implementation. Work around this by using the gnu libiconv.

https://lists.gnu.org/archive/html/bug-gnulib/2024-05/msg00375.html

alternative to: #364495
closes: #364495

results in under 8k rebuilds

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 12, 2024
@paparodeo paparodeo force-pushed the guile-fix-darwin branch 2 times, most recently from b67e5fc to 265ae55 Compare December 12, 2024 08:42
@paparodeo paparodeo changed the base branch from master to staging-next December 12, 2024 08:42
guile will fail in the configure phase on darwin due to libunistring not
building with libiconv as libunistring 1.3 rejects darwin's libiconv
implementation. Work around this by using the gnu libiconv.

https://lists.gnu.org/archive/html/bug-gnulib/2024-05/msg00375.html
@paparodeo paparodeo changed the title [WIP] guile: workaround for libunistring / darwin libiconv guile: workaround for libunistring / darwin libiconv Dec 12, 2024
@paparodeo paparodeo marked this pull request as ready for review December 12, 2024 09:42
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ labels Dec 12, 2024
@vcunat vcunat merged commit 6d0b733 into NixOS:staging-next Dec 13, 2024
57 of 58 checks passed
@paparodeo paparodeo deleted the guile-fix-darwin branch December 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants