Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coolercontrol.*: 1.4.4 -> 1.4.5 #365358

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

codifryed
Copy link
Contributor

@codifryed codifryed commented Dec 15, 2024

Changes: (Minor)
https://gitlab.com/coolercontrol/coolercontrol/-/releases/1.4.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@codifryed codifryed requested a review from OPNA2608 December 15, 2024 12:53
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 15, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 15, 2024
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto_2024-12-16_14-08-38

LGTM. Let's backport this to stable too: Listed changes seem fine, and having https://gitlab.com/coolercontrol/coolercontrol/-/issues/238 fixed again would be nice.

@OPNA2608 OPNA2608 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically labels Dec 16, 2024
@OPNA2608 OPNA2608 merged commit c1fd42d into NixOS:master Dec 16, 2024
49 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 16, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-365358-to-release-24.11 origin/release-24.11
cd .worktree/backport-365358-to-release-24.11
git switch --create backport-365358-to-release-24.11
git cherry-pick -x 81806e544faca8bb85bdfd79e8212a61709e0d58

@OPNA2608
Copy link
Contributor

Ahh, #358289 isn't backported yet… Let's send that too then.

@OPNA2608 OPNA2608 removed the backport release-24.11 Backport PR automatically label Dec 16, 2024
@OPNA2608
Copy link
Contributor

#365598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants