rwalk: init at 0.9.0

[pwnwriter]

Description of changes

A blazingly fast web directory scanner written in Rust

https://github.com/cestef/rwalk

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[steeleduncan]

@pwnwriter Looks good to me, but I don't have commit access, and don't maintain a similar package, so it doesn't make sense for me to leave an approving review. Once the tests have passed, my suggestion to get it merged would be to find someone who has merged a rust tool comparable to this into nixpkgs recently, and ping them for a review

[pwnwriter]

@drupol, could you please check and merge ? Appreciate it :)

[drupol]

IIRC, embedding the cargo.lock file is not necessary any more. Have a look at https://github.com/NixOS/nixpkgs/blob/nixos-24.11/pkgs/by-name/ty/typst/package.nix#L79

[pwnwriter]

@GaetanLepage , I've committed the requested changes, But the ci fails now. Could you please guide me on this?

[drupol]

@GaetanLepage , I've committed the requested changes, But the ci fails now. Could you please guide me on this?

Run nixfmt-rfc-style on your nix file to fix the formatting

[pwnwriter]

should I now remove the lock file?

[GaetanLepage]

should I now remove the lock file?

Yes. Also, replace the "..." with the correct hash.
And add

passthru = {
  updateScript = nix-update-script { };
};

just before meta =

[pwnwriter]

@GaetanLepage Could you tell me how'd I retrieve the cargo hash? I thought it'll provide me if I try to build it. But yeah, I'm getting issue with nix-update-script not sure If it's intended.

[GaetanLepage]

@GaetanLepage Could you tell me how'd I retrieve the cargo hash? I thought it'll provide me if I try to build it. But yeah, I'm getting issue with nix-update-script not sure If it's intended.

For cargoHash, set it to an empty string (""), build it. The error message will contain the right hash.

For nix-update-script, you need to add it to the derivation inputs at the top of the file.

[pwnwriter]

The upstream repo doesn't provide Cargo lock file. I think I should first make a pr there and then will make changes here?

[GaetanLepage]

The upstream repo doesn't provide Cargo lock file. I think I should first make a pr there and then will make changes here?

Good point, I had not checked this.
So, switch back to vendoring the Cargo.lock in nixpkgs as you had done initially.
In the mean time, you could open an issue/PR upstream to ask them to track their Cargo.lock. No need to wait for them though.

[pwnwriter]

The version has been bumped from 0.8.7 to 0.9.0. Should I discard this pr and create a new one as a follow up or this is fine as it is?

[GaetanLepage]

The version has been bumped from 0.8.7 to 0.9.0. Should I discard this pr and create a new one as a follow up or this is fine as it is?

No, just force-push to this one. Update directly to 0.9.0.

[pwnwriter]

done

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366586

---

x86_64-linux

✅ 1 package built:

• rwalk

---

aarch64-linux

✅ 1 package built:

• rwalk

---

x86_64-darwin

✅ 1 package built:

• rwalk

---

aarch64-darwin

✅ 1 package built:

• rwalk

[GaetanLepage]

LGTM, well done @pwnwriter :)