upcloud-cli: init at 3.14.0

[lu1a]

Introducing upcloud-cli as a nix pkg.
upcloud-cli is a command-line tool for managing UpCloud services.
Source: https://github.com/UpCloudLtd/upcloud-cli

I also added myself as a maintainer.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[lucasew]

Just let them run then check the ones that are failing Em qua., 25 de dez. de 2024 16:24, Lewis ***@***.***> escreveu:

…

***@***.**** commented on this pull request. ------------------------------ In pkgs/tools/admin/upcloud-cli/default.nix <#368124 (comment)>: > +}: + +buildGoModule rec { + pname = "upcloud-cli"; + version = "3.13.0"; + + src = fetchFromGitHub { + owner = "UpCloudLtd"; + repo = "upcloud-cli"; + rev = "refs/tags/v${version}"; + hash = "sha256-0hXqqLqZLX9zkRk6/sOh3/w+v5piuAV1277Nk6w1i6s="; + }; + + vendorHash = "sha256-Sl9D8PyqWfTBrPsVxJtLmU3Qxe5f3kpwd5Oi+5YZ4oo="; + + doCheck = false; Should I exhaustively try to find tests that attempt to reach the internet, or is it fine that I was able to run all the tests successfully with no connection? — Reply to this email directly, view it on GitHub <#368124 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXXO6BJEGCMWHEHWVHFQWT2HMA57AVCNFSM6AAAAABUGAEOJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRSGY2TENJQG4> . You are receiving this because you commented.Message ID: ***@***.***>

[steeleduncan]

You should squash the changes into two commits. One altering the maintainers list, and one adding the package

[lucasew]

also, please rename the commit to the same name as the PR

[lucasew]

Diff LGTM

nixpkgs-review in queue, gonna test later

[lucasew]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368124

---

x86_64-linux

✅ 1 package built:

• upcloud-cli

[lu1a]

A new version came out in the meantime, so I just updated this PR to be 3.14.0 instead of waiting until this is merged and creating a separate update PR. Hope that's fine.

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368124

---

x86_64-linux

❌ 1 package failed to build:

• upcloud-cli

---

aarch64-linux

❌ 1 package failed to build:

• upcloud-cli

---

x86_64-darwin

❌ 1 package failed to build:

• upcloud-cli

---

aarch64-darwin

❌ 1 package failed to build:

• upcloud-cli

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368124

---

x86_64-linux

✅ 1 package built:

• upcloud-cli

---

aarch64-linux

✅ 1 package built:

• upcloud-cli

---

x86_64-darwin

✅ 1 package built:

• upcloud-cli

---

aarch64-darwin

✅ 1 package built:

• upcloud-cli

[GaetanLepage]

Nice work, thank you @lu1a