Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuda-modules: fix sort predicate stability #368366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cuda-modules: fix sort predicate stability #368366

wants to merge 1 commit into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Dec 26, 2024 •
edited
Loading

Incorrect sorting predicate was found as part of
NixOS/nix#12106 where nix was crashing on the code like:

$ nix eval --expr 'builtins.sort (a: b: true) [ 1 2 3 ]'
...
Aborted (core dumped)

Note: the crash happens here because sorting predicate does not implement isLess and triggers assertion failures for std::stable_sort that backs builtins.sort.

THe change restore isLess semantic for preferable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
cuda-modules: fix sort predicate stability
5e4541b 
Incorrect sorting predicate was found as part of
NixOS/nix#12106 where `nix` was crashing on
the code like:

    $ nix eval --expr 'builtins.sort (a: b: true) [ 1 2 3 ]'
    ...
    Aborted (core dumped)

Note: the crash happens here because sorting predicate does not
implement `isLess` and triggers assertion failures for
`std::stable_sort` that backs `builtins.sort`.

THe change restore `isLess` semantic for `preferable`.
@github-actions github-actions bot added the 6.topic: cuda Parallel computing platform and API label Dec 26, 2024
@SomeoneSerge
Copy link
Contributor

SomeoneSerge commented Dec 26, 2024 •
edited
Loading

This should be good, but off the top of my head I can't immediately tell why Ofborg failed with

       error: attribute 'lib' missing

       at /ofborg/checkout/2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-4/pkgs/development/python-modules/torch/default.nix:369:30:

          368|       export CUDNN_INCLUDE_DIR=${lib.getLib cudnn}/include
          369|       export CUDNN_LIB_DIR=${cudnn.lib}/lib

...a riddle for the next morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cuda Parallel computing platform and API
Projects
CUDA Team
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @SomeoneSerge