treewide/nixos: remove with lib; part 10
#369233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-10
branch
2 times, most recently
from
c7199a1 to
fd575bc
Compare
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-10
branch
from
fd575bc to
336a76b
Compare
lucasew
reviewed
Dec 31, 2024
| @@ -5,10 +5,7 @@ | |||
| pkgs, | |||
| ... | |||
| }: | |||
|
|
|||
| with builtins; | |||
There was a problem hiding this comment.
Maybe that should be removed too. Out of scope but can be an extra mile.
There was a problem hiding this comment.
could have prevented #369869.
There was a problem hiding this comment.
BTW this kind of stuff is a breeze to do with a nice LSP
When there is not a top level with the LSP points all the missing stuff. Only jump through the diagnostic list fixing stuff.
There was a problem hiding this comment.
BTW this kind of stuff is a breeze to do with a nice LSP
nixd is my cup of tea for this very reason.
lucasew
approved these changes
Dec 31, 2024
wegank
added
the
12.approvals: 1
thiagokokada
approved these changes
Dec 31, 2024
13 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.