Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide/nixos: remove with lib; part 13 #369420

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

treewide/nixos: remove with lib; part 13 #369420

wants to merge 49 commits into from

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

part of #208242

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey
nixos/services.xserver.windowManager.evilwm: remove with lib;
9559e2c
@Stunkymonkey
nixos/services.xserver.windowManager.exwm: remove with lib;
b1f6a38
@Stunkymonkey
nixos/services.xserver.windowManager.fluxbox: remove with lib;
6511cae
@Stunkymonkey
nixos/services.xserver.windowManager.fvwm2: remove with lib;
6752537
@Stunkymonkey
nixos/services.xserver.windowManager.fvwm3: remove with lib;
988ad01
@Stunkymonkey
nixos/services.xserver.windowManager.hackedbox: remove with lib;
c7eb737
@Stunkymonkey
nixos/services.xserver.windowManager.herbstluftwm: remove with lib;
a43e142
@Stunkymonkey
nixos/services.xserver.windowManager.hypr: remove with lib;
65bf2e7
@Stunkymonkey
nixos/services.xserver.windowManager.i3: remove with lib;
81734be
@Stunkymonkey
nixos/services.xserver.windowManager.icewm: remove with lib;
fd6e177
@Stunkymonkey
nixos/services.xserver.windowManager.leftwm: remove with lib;
cdfd097
@Stunkymonkey
nixos/services.xserver.windowManager.lwm: remove with lib;
849a9ba
@Stunkymonkey
nixos/services.xserver.windowManager.mlvwm: remove with lib;
191cac7
@Stunkymonkey
nixos/services.xserver.windowManager.mwm: remove with lib;
ad72672
@Stunkymonkey
nixos/services.xserver.windowManager.nimdow: remove with lib;
3a85d3c
@Stunkymonkey
nixos/services.xserver.windowManager.notion: remove with lib;
4ddad25
@Stunkymonkey
nixos/services.xserver.windowManager.openbox: remove with lib;
e154a91
@Stunkymonkey
nixos/services.xserver.windowManager.pekwm: remove with lib;
cfa9067
@Stunkymonkey
nixos/services.xserver.windowManager.qtile: remove with lib;
05f7b04
@Stunkymonkey
nixos/services.xserver.windowManager.ragnarwm: remove with lib;
33694b4
@Stunkymonkey
nixos/services.xserver.windowManager.ratpoison: remove with lib;
167f8a9
@Stunkymonkey
nixos/services.xserver.windowManager.sawfish: remove with lib;
768e928
@Stunkymonkey
nixos/services.xserver.windowManager.smallwm: remove with lib;
8a1e885
@Stunkymonkey
nixos/services.xserver.windowManager.spectrwm: remove with lib;
96f86e3
@Stunkymonkey
nixos/services.xserver.windowManager.stumpwm: remove with lib;
a606d6c
@Stunkymonkey
nixos/services.xserver.windowManager.windowmaker: remove with lib;
0123b80
@Stunkymonkey
nixos/services.xserver.windowManager.xmonad: remove with lib;
0a34fc4
@Stunkymonkey
nixos/services.xserver.windowManager.yeahwm: remove with lib;
f2ec80c
@Stunkymonkey
nixos/services.xserver.xautolock: remove with lib;
c5dd0bf
@Stunkymonkey
nixos/services.xbanish: remove with lib;
8d87c6b
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd labels Dec 30, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-13 branch from 19be63f to 02b8594 Compare December 30, 2024 15:21
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2024
@Stunkymonkey Stunkymonkey marked this pull request as ready for review December 30, 2024 16:00
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
lucasew
lucasew approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@lucasew lucasew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

Rebase it to solve conflicts.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew lucasew approved these changes

@philiptaron philiptaron Awaiting requested review from philiptaron

@aanderse aanderse Awaiting requested review from aanderse

@arianvp arianvp Awaiting requested review from arianvp

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @lucasew @wegank