glibc: don't use bootstrap libgcc_s #36948

dtzWill · 2018-03-14T01:14:52Z

Fixes #36947

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Huge rebuild, have not tested everything obviously :).

Wanted to see what broke and was surprised to find
that things didn't immediately and completely break.

I'm curious if clang works after this, we'll see!

GrahamcOfBorg · 2018-03-14T01:24:59Z

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: glibc

No log is available.

GrahamcOfBorg · 2018-03-14T01:31:05Z

Success on aarch64-linux (full log)

Attempted: glibc

Partial log (click to expand)

cannot find section .dynamic
moving /nix/store/8jga76ik7x3wfsg5m2hf9jmbdxczzgsf-glibc-2.26-131-bin/sbin/* to /nix/store/8jga76ik7x3wfsg5m2hf9jmbdxczzgsf-glibc-2.26-131-bin/bin
checking for references to /build in /nix/store/r45ws72pm72hba06dd69gw3w6qhjigzz-glibc-2.26-131-dev...
could not find build ID of /nix/store/0mgm69j09xql4vsb063hlwc31l04kzjj-glibc-2.26-131-static/lib/libmcheck.a, skipping
could not find build ID of /nix/store/0mgm69j09xql4vsb063hlwc31l04kzjj-glibc-2.26-131-static/lib/libieee.a, skipping
checking for references to /build in /nix/store/0mgm69j09xql4vsb063hlwc31l04kzjj-glibc-2.26-131-static...
wrong ELF type
wrong ELF type
checking for references to /build in /nix/store/3gg8dg63z571zzj152rd4h70psbh5qxf-glibc-2.26-131-debug...
/nix/store/0hsa094362ksjmfr8klay9wkj85frd49-glibc-2.26-131

GrahamcOfBorg · 2018-03-14T01:53:24Z

Success on x86_64-linux (full log)

Attempted: glibc

Partial log (click to expand)

cannot find section .dynamic
moving /nix/store/nwrvymzvv0xp2rslag6crfc018dwwndz-glibc-2.26-131-bin/sbin/* to /nix/store/nwrvymzvv0xp2rslag6crfc018dwwndz-glibc-2.26-131-bin/bin
checking for references to /build in /nix/store/v1qs4k70dbh094ms4qmvjncsnfw5m5b7-glibc-2.26-131-dev...
could not find build ID of /nix/store/bzj1lrd6qghn0bj6i12i4pv3ymsxssga-glibc-2.26-131-static/lib/libieee.a, skipping
could not find build ID of /nix/store/bzj1lrd6qghn0bj6i12i4pv3ymsxssga-glibc-2.26-131-static/lib/libmcheck.a, skipping
checking for references to /build in /nix/store/bzj1lrd6qghn0bj6i12i4pv3ymsxssga-glibc-2.26-131-static...
wrong ELF type
wrong ELF type
checking for references to /build in /nix/store/nsxjns63rfg6dlf10hl213vdk4404wkx-glibc-2.26-131-debug...
/nix/store/jcs0l7vdp162qjixs0i7wdxva303dh59-glibc-2.26-131

dtzWill · 2018-03-14T03:01:40Z

Yep, tests.cc-wrapper-clang-5 fails with this, as expected. Need to teach it to find libs in gcc.lib or perhaps create a merged variant and point clang at that...

dtzWill · 2018-03-14T03:04:09Z

build log of the failure, for the curious: https://gist.github.com/dtzWill/9aea1fb5695788fcb0a63c96f32d36d4

This is the error we currently find w/trying to use clang as a cross-compiler, which is what started me looking into all of this :).

cc #36867

Mic92 · 2018-03-14T10:22:57Z

@dtzWill if you are at it, could you maybe also teach clang to find c++ stdlib headers without compiler wrappers on linux? This would fix all tooling that uses libclang. I tried to fix it in https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/Linux.cpp#L758 but this only affects clang from a build directory.

Mic92 · 2018-03-14T10:24:09Z

that one looks also interesting: https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/Linux.cpp#L804

Ericson2314 · 2018-03-14T13:42:32Z

Yeah we need to get change GCC at some point so the compiler itself and runtime libraries are built separately. That will make the one problem caused by this go away!

vcunat · 2018-03-14T14:37:53Z

Hmm, I suppose we can afford this now that we have gcc.lib split away.

Ekleog · 2018-03-14T15:20:46Z

Hmm, I think this issue is currently making some builds fail for 18.03, esp. ones that are required for the channel to move forward and actually come into existence (spidermonkey_38 for i686 in particular is required by tests that are required for 18.03, if I read hydra correctly).

Would it make sense to merge this PR into release-18.03 and see what happens, so that we get a better idea of what exactly is broken by it? Anyway I feel like the channel won't move forward until this PR or a similar one is merged, so I don't think there is much to lose (apart from hydra building time)?

(cc ZHF #36453)

vcunat · 2018-03-14T17:02:44Z

Eh, better not do such experiments directly on 18.03 anymore. After it's confirmed that this works good, we can cherry-pick it in 18.03. We may have a separate temporary jobset if you think there's a risk of mass breakage, but I suppose it won't be that risky.

pbogdan · 2018-03-14T17:09:03Z

Plus 18.03's tested job already succeeded so as I understand it this shouldn't block channel updates (I can't see the channel being created yet but I suppose that's a different issue).

dtzWill · 2018-03-14T17:13:42Z

Perhaps a new jobset would be appropriate then?

Ekleog · 2018-03-14T17:43:13Z

@pbogdan oh indeed, I was misreading the jobs tab as the tested job, because I didn't understand why 18.03 hadn't been created yet -- my reasoning was completely wrong, then, sorry for the noise :)

Ericson2314 · 2018-03-15T02:21:54Z

I added the 18.09 milestone because I definitely want this to happen by then. Not trying to say it shouldn't also happen for 18.03 :).

vcunat · 2018-03-15T17:53:04Z

For reference, the 18.03 channels are there now, for about a day. The machine bumping them wasn't immediately re-deployed with the new configuration, by mistake.

Ericson2314 · 2018-03-27T03:29:07Z

Can we still do this? A quick hack for LLVM in cc-wrapper should be easy enough.

dtzWill · 2018-05-02T12:41:09Z

Agreed, and we can probably improve the libclang situation while we're at it.

Definitely want this to happen, just not sure when :)

lopsided98 · 2018-05-20T17:33:09Z

Doing this would make everything that needs on libgcc_s.so depend on gcc, right? Shouldn't we have a libgcc package like pretty much every other distribution to avoid this?

Ericson2314 · 2018-05-22T19:39:45Z

We soon will for compiler-rt! #39743

GrahamcOfBorg · 2018-11-02T09:54:44Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: pkgsi686Linux.dejagnu

Partial log (click to expand)

cannot build derivation '/nix/store/46i4abslll9px32gdiqhmqy6g71qy794-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/pph0yn3wla4idmy5rdrrfdvfqcrrnipz-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/0wr8wi99cljhmjzk3hznym4ffra5vrk1-stdenv-linux.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/yfjcxdg24qf2drdibgpgq4bmkcy5l5nm-stdenv-linux.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/6bq22cai0890gnsnz0cl3579bjspyy88-hook.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y5i5gcdp78c1fcqrdw4pw3zlfhxj1kp0-tcl-8.6.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/riy20wqr2jq9j1xvanwldlx48m5fcwmc-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/9i0qyghb3pwv6nvcx2fp5jkhxhfaiasl-expect-5.45.4.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/x6ndlqzda010q1hf90yri3n6axdwzdm1-dejagnu-1.6.1.drv': 4 dependencies couldn't be built
error: build of '/nix/store/x6ndlqzda010q1hf90yri3n6axdwzdm1-dejagnu-1.6.1.drv' failed

Fixes NixOS#36947

The underlying problem with libgcc is worked around. (cherry picked from commit afea12f)

GrahamcOfBorg · 2018-11-04T00:22:46Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: glibc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-11-04T00:26:15Z

Success on aarch64-linux (full log)

Attempted: glibc

Partial log (click to expand)

checking for references to /build in /nix/store/wsa5nkdf644ryv9p8zpn2d2qwsva9dff-glibc-2.27-bin...
cannot find section .dynamic
cannot find section .dynamic
moving /nix/store/wsa5nkdf644ryv9p8zpn2d2qwsva9dff-glibc-2.27-bin/sbin/* to /nix/store/wsa5nkdf644ryv9p8zpn2d2qwsva9dff-glibc-2.27-bin/bin
checking for references to /build in /nix/store/5ds0vi1w2fki4v061ppm5xp225dgyw7j-glibc-2.27-dev...
could not find build ID of /nix/store/0a1hhqqcvp4akjd1s20wq3qx298ld4in-glibc-2.27-static/lib/libmcheck.a, skipping
checking for references to /build in /nix/store/0a1hhqqcvp4akjd1s20wq3qx298ld4in-glibc-2.27-static...
wrong ELF type
checking for references to /build in /nix/store/8w2dkwgjd22xbqlmvyjpd1rvwm77yrar-glibc-2.27-debug...
/nix/store/4y1w2p3c5m0gh9xphfir1zfw09jan57f-glibc-2.27

GrahamcOfBorg · 2018-11-04T00:55:14Z

Success on x86_64-linux (full log)

Attempted: glibc

Partial log (click to expand)

checking for references to /build in /nix/store/3713rx0rbs3mjyny61warmd0ain3wmfi-glibc-2.27-bin...
cannot find section .dynamic
cannot find section .dynamic
moving /nix/store/3713rx0rbs3mjyny61warmd0ain3wmfi-glibc-2.27-bin/sbin/* to /nix/store/3713rx0rbs3mjyny61warmd0ain3wmfi-glibc-2.27-bin/bin
checking for references to /build in /nix/store/0p4swxfiga1y4xzb6db9wxbwyxw9dk5k-glibc-2.27-dev...
could not find build ID of /nix/store/5yzm7bdpvlrhfrgcpzlmf465brfxk9dr-glibc-2.27-static/lib/libmcheck.a, skipping
checking for references to /build in /nix/store/5yzm7bdpvlrhfrgcpzlmf465brfxk9dr-glibc-2.27-static...
wrong ELF type
checking for references to /build in /nix/store/yim1ca15is3k2zld4ywci4pl7d6cv7l2-glibc-2.27-debug...
/nix/store/mk5bqc17fvjxif36k13r3nikfl381x4f-glibc-2.27

pbogdan · 2019-01-24T02:55:31Z

FWIW dejagnu is broken on x86_64-linux and i686-linux with these changes. As I understand it the library may be dynamically loaded by glibc at runtime which makes hunting down failures more difficult (in this case it seems it's some code in tcl that triggers loading the library which is no longer available on the search path).

pbogdan · 2019-01-24T17:17:01Z

gnutls test suite fails too.

matthewbauer · 2019-01-24T20:35:51Z

@dtzWill is there any way to avoid these issues? I still like getting rid of references to libgcc... But it may need to wait for another time?

matthewbauer · 2019-01-27T01:37:44Z

Ok let's revert for now. ideally we can get this fixed at a later point. 319ebef is the revert.

This reverts commit 80ff19a, reversing changes made to 43e867a.

dtzWill · 2019-01-27T22:45:30Z

Aww can't reopen this? 😿

Suppose can always make a new one if someone finds time to tackle the issues.

Not sure I prefer the current state (subtle issues everywhere) over breaking things explicitly and forcing the issue, but that's just me O:). Probably not best to do that with a release looming, I admit... :)

Let's try this again. See NixOS#36947 and NixOS#36948 for history

ghost · 2023-01-11T22:11:29Z

I figured out the root cause of these segfaults.

GrahamcOfBorg added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ labels Mar 14, 2018

Ericson2314 mentioned this pull request Mar 15, 2018

Make "localizations" sane again #37012

Merged

Ericson2314 added this to the 18.09 milestone Mar 15, 2018

Ericson2314 added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Mar 15, 2018

Ericson2314 mentioned this pull request Mar 15, 2018

Cross glibc retains references to static gcc #35251

Closed

Ericson2314 mentioned this pull request Mar 15, 2018

glibc: Strip bonus libraries #37056

Open

vcunat mentioned this pull request May 20, 2018

libgcc_s.so is missing from glibc when cross compiling #40797

Closed

dtzWill and others added 2 commits November 3, 2018 19:05

glibc: don't use bootstrap libgcc_s

64b3350

Fixes NixOS#36947

all-packages.nix: Remove gcc7 i686 workarounds

ff30d7b

The underlying problem with libgcc is worked around. (cherry picked from commit afea12f)

dtzWill force-pushed the fix/glibc-libgcc_s branch from 38b17f5 to ff30d7b Compare November 4, 2018 00:08

matthewbauer force-pushed the fix/glibc-libgcc_s branch 2 times, most recently from 8d7d962 to e26c8aa Compare January 23, 2019 21:52

Merge branch 'staging' into fix/glibc-libgcc_s

2ed8ee4

matthewbauer force-pushed the fix/glibc-libgcc_s branch from e26c8aa to 2ed8ee4 Compare January 23, 2019 21:53

GrahamcOfBorg requested review from edolstra, lovek323 and andir January 23, 2019 22:09

matthewbauer merged commit 80ff19a into NixOS:staging Jan 23, 2019

pbogdan mentioned this pull request Jan 24, 2019

[staging] dejagnu tests fail #54540

Closed

matthewbauer added a commit that referenced this pull request Jan 27, 2019

Revert "Merge pull request #36948 from dtzWill/fix/glibc-libgcc_s"

319ebef

This reverts commit 80ff19a, reversing changes made to 43e867a.

Gaelan added a commit to Gaelan/nixpkgs that referenced this pull request Apr 28, 2022

glibc: stop using bootstrap libgcc_s

e545700

Let's try this again. See NixOS#36947 and NixOS#36948 for history

ajs124 pushed a commit to helsinki-systems/nixpkgs that referenced this pull request Oct 22, 2022

glibc: stop using bootstrap libgcc_s

f88a302

Let's try this again. See NixOS#36947 and NixOS#36948 for history

zzywysm mentioned this pull request Nov 28, 2022

build the kernel with a newer gcc tpwrules/nixos-apple-silicon#11

Closed

This was referenced Jan 9, 2023

stdenv: Nix-driven bootstrap of gcc #209870

Merged

glibc: add enableCopyLibGccHack #210112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

glibc: don't use bootstrap libgcc_s #36948

glibc: don't use bootstrap libgcc_s #36948

dtzWill commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

dtzWill commented Mar 14, 2018

dtzWill commented Mar 14, 2018

Mic92 commented Mar 14, 2018

Mic92 commented Mar 14, 2018

Ericson2314 commented Mar 14, 2018

vcunat commented Mar 14, 2018

Ekleog commented Mar 14, 2018

vcunat commented Mar 14, 2018

pbogdan commented Mar 14, 2018

dtzWill commented Mar 14, 2018

Ekleog commented Mar 14, 2018

Ericson2314 commented Mar 15, 2018 •

edited

Loading

vcunat commented Mar 15, 2018 •

edited

Loading

Ericson2314 commented Mar 27, 2018

dtzWill commented May 2, 2018

lopsided98 commented May 20, 2018

Ericson2314 commented May 22, 2018

GrahamcOfBorg commented Nov 2, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

pbogdan commented Jan 24, 2019

pbogdan commented Jan 24, 2019

matthewbauer commented Jan 24, 2019

matthewbauer commented Jan 27, 2019

dtzWill commented Jan 27, 2019

ghost commented Jan 11, 2023

glibc: don't use bootstrap libgcc_s #36948

glibc: don't use bootstrap libgcc_s #36948

Conversation

dtzWill commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

dtzWill commented Mar 14, 2018

dtzWill commented Mar 14, 2018

Mic92 commented Mar 14, 2018

Mic92 commented Mar 14, 2018

Ericson2314 commented Mar 14, 2018

vcunat commented Mar 14, 2018

Ekleog commented Mar 14, 2018

vcunat commented Mar 14, 2018

pbogdan commented Mar 14, 2018

dtzWill commented Mar 14, 2018

Ekleog commented Mar 14, 2018

Ericson2314 commented Mar 15, 2018 • edited Loading

vcunat commented Mar 15, 2018 • edited Loading

Ericson2314 commented Mar 27, 2018

dtzWill commented May 2, 2018

lopsided98 commented May 20, 2018

Ericson2314 commented May 22, 2018

GrahamcOfBorg commented Nov 2, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

pbogdan commented Jan 24, 2019

pbogdan commented Jan 24, 2019

matthewbauer commented Jan 24, 2019

matthewbauer commented Jan 27, 2019

dtzWill commented Jan 27, 2019

ghost commented Jan 11, 2023

Ericson2314 commented Mar 15, 2018 •

edited

Loading

vcunat commented Mar 15, 2018 •

edited

Loading