Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs_22: fix build with libuv 1.48.0 #371201

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 5, 2025

Refs: #371149 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it, thanks!

@emilazy emilazy merged commit d12e97e into NixOS:staging-next-24.11 Jan 5, 2025
24 of 28 checks passed
@emilazy
Copy link
Member

emilazy commented Jan 5, 2025

@aduh95 Unfortunately, on x86_64-darwin:

not ok 2411 parallel/test-runner-complex-dependencies
  ---
  duration_ms: 495.17300
  severity: fail
  exitcode: 1
  stack: |-
    TAP version 13
    # Subtest: test runner watch mode with more complex setup
        # Subtest: should re-run appropriate tests when dependencies change
        not ok 1 - should re-run appropriate tests when dependencies change
          ---
          duration_ms: 249.063667
          location: '/private/tmp/nix-build-nodejs-22.12.0.drv-0/node-v22.12.0/test/parallel/test-runner-complex-dependencies.mjs:37:3'
          failureType: 'cancelledByParent'
          error: 'Promise resolution is still pending but the event loop has already resolved'
          code: 'ERR_TEST_FAILURE'
          stack: |-
            process.emit (node:events:524:28)
          ...
        1..1
    not ok 1 - test runner watch mode with more complex setup
      ---
      duration_ms: 249.356709
      type: 'suite'
      location: '/private/tmp/nix-build-nodejs-22.12.0.drv-0/node-v22.12.0/test/parallel/test-runner-complex-dependencies.mjs:36:1'
      failureType: 'cancelledByParent'
      error: 'Promise resolution is still pending but the event loop has already resolved'
      code: 'ERR_TEST_FAILURE'
      stack: |-
        process.emit (node:events:524:28)
      ...
    1..1
    # tests 1
    # suites 1
    # pass 0
    # fail 0
    # cancelled 1
    # skipped 0
    # todo 0
    # duration_ms 252.832
  ...
not ok 3194 parallel/test-watch-file-shared-dependency
  ---
  duration_ms: 175.84200
  severity: fail
  exitcode: 1
  stack: |-
    TAP version 13
    # Subtest: watch file with shared dependency
        # Subtest: should not remove shared dependencies when unfiltering an owner
        ok 1 - should not remove shared dependencies when unfiltering an owner
          ---
          duration_ms: 1.625334
          ...
        1..1
    ok 1 - watch file with shared dependency
      ---
      duration_ms: 2.398416
      type: 'suite'
      ...
    1..1
    # Error: Test "should not remove shared dependencies when unfiltering an owner" at test/parallel/test-watch-file-shared-dependency.mjs:35:3 generated asynch>
    # tests 1
    # suites 1
    # pass 1
    # fail 0
    # cancelled 0
    # skipped 0
    # todo 0
    # duration_ms 9.825
  ...

@aduh95 aduh95 deleted the nodejs-22-libuv-reverts branch January 5, 2025 21:53
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 5, 2025

I cannot reproduce on aarch64-darwin

@emilazy
Copy link
Member

emilazy commented Jan 5, 2025

My guess is that it’s more Rosetta 2 weirdness, but it’s strange that it would only be happening on 24.11 (libuv related?), and a little unfortunate that we’ve traded one mysterious x86_64-darwin test failure for two. But maybe it won’t happen on Hydra, and at least it’s not the default version…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants