lesspipe: 2.14 -> 2.17 #371214
Merged
lesspipe: 2.14 -> 2.17 #371214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sersorrel
added
1.severity: security
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-371214-to-release-24.11 origin/release-24.11
cd .worktree/backport-371214-to-release-24.11
git switch --create backport-371214-to-release-24.11
git cherry-pick -x 4b487410b65093fdb9de269b0b86aeee1ca481d3 7233b53e3c3d484f7f29eca9073135dbf1a871b3 |
|
@sersorrel sorry for the delay! I was just looking over this as the merge was happening 😆 excited to see it in! Hopefully it gets into 24.11 (although looks like we're still stuck on 2.11 there). |
| @@ -85,89 +85,84 @@ stdenv.mkDerivation rec { | |||
| ]; | |||
| fake = { | |||
| # script guards usage behind has_cmd test function, it's safe to leave these external and optional | |||
| external = | |||
There was a problem hiding this comment.
This is nothing you can fix but this behaviour by the new formatter is really dumb.
1 task
sersorrel
added
backport release-24.11
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression which completely broke lesspipe for bat users with specific config options, and includes a security fix related to
ar.resholve appears to complain about
localefor me on x86_64-linux now (possibly as a result of wofr06/lesspipe@23e0e4d?), so it's now just included inexternalunconditionally.Changelog: https://github.com/wofr06/lesspipe/blob/v2.17/ChangeLog
Fixes #371076
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.