Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensnitch-ui: fix runtime crash #372352

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

LordGrimmauld
Copy link
Contributor

this broke in PR #370048 / commit 293f832, as the packaging python package is now required at runtime

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2025
@LordGrimmauld
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372352


x86_64-linux

✅ 2 packages built:
  • opensnitch-ui
  • opensnitch-ui.dist

@nix-owners nix-owners bot requested a review from onny January 9, 2025 12:28
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
this broke in PR NixOS#370048 / commit 293f832, as the packaging python package is now required at runtime
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
@LordGrimmauld LordGrimmauld added 12.approvals: 1 This PR was reviewed and approved by one reputable person 6.topic: python labels Jan 11, 2025
Copy link
Contributor

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Crashed before on startup

@mohe2015 mohe2015 added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 14, 2025
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372352


x86_64-linux

✅ 2 packages built:
  • opensnitch-ui
  • opensnitch-ui.dist

aarch64-linux

✅ 2 packages built:
  • opensnitch-ui
  • opensnitch-ui.dist

@GaetanLepage GaetanLepage merged commit ce2179d into NixOS:master Jan 15, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants