-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mitmproxy: 11.0.2 -> 11.1.3; python3Packages.mitmproxy-rs: 0.10.7 -> 0.11.5; python3Packages.mitmproxy-linux: init at 0.11.5 #373425
base: staging
Are you sure you want to change the base?
Conversation
I don't know why mitmproxy pulling old version of mitmproxy
|
@SuperSandro2000 mitmproxy seperated linux part to mitmproxy-linux like mitmproxy-macos, I want to hear your opinion.
|
If mitmproxy-rs is unused in tree then we don't need it and should delete it. |
mitmproxy-linux requires rust-src, how can I add it? full log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
|
I don't see an env how to point it to that. Also so far I couldn't figure out which step exactly wants the src but the source will be in rustPlatform.rustLibSrc |
I think aya-ebpf might be causing the rust nightly dependency. https://github.com/aya-rs/aya not sure what to do here. |
maybe we can fetch from https://pypi.org/project/mitmproxy-linux like mitmproxy-macos |
I looked rust doc and it says -Z build-std needs nightly version of rustc, rust-src and cargo. |
ffbdf8f
to
b65cbbf
Compare
I tried patching that out earlier but we should try it again more aggressively. If that doesn't work we just fetch it from nine source if possible |
2461de8
to
d1a2dba
Compare
d1a2dba
to
c05c490
Compare
and it finally built!!!! 🎉 We are now waiting for #382166 and if that is merged I retarget this PR to staging/-next and merge it to there. |
0ef637c
to
9def86d
Compare
9def86d
to
58ef363
Compare
58ef363
to
9dac890
Compare
Co-Authored-By: misilelab <misileminecord@gmail.com>
9dac890
to
509855d
Compare
rustPlatform.maturinBuildHook | ||
]; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM!
https://github.com/mitmproxy/mitmproxy/blob/v11.1.3/CHANGELOG.md
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.