Skip to content

Conversation

@ddogfoodd
Copy link
Contributor

Changelog: https://github.com/jesseduffield/lazygit/releases
Diff: jesseduffield/lazygit@v0.45.2...v0.46.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 15, 2025
@ddogfoodd
Copy link
Contributor Author

Just tried to build with the Go 1.22 enforcing removed, still seems to work for me.
The issue that was commented in the package.nix is still open but should be resolved by jesseduffield/lazygit#4248 which was mentioned in the changelog.

@kirillrdy
Copy link
Member

kirillrdy commented Feb 15, 2025

@ddogfoodd can you add links to changelog and diff to commit message

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

@ddogfoodd
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382262


x86_64-linux

✅ 1 package built:
  • lazygit

@ddogfoodd
Copy link
Contributor Author

@kirillrdy thank you, somehow missed that up until now, will do better in the future!

Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that deadlock has been fixed

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382262


aarch64-linux

✅ 1 package built:
  • lazygit

@kirillrdy kirillrdy merged commit 19b62b0 into NixOS:master Feb 15, 2025
26 of 27 checks passed
@ddogfoodd ddogfoodd deleted the update-lazygit branch February 15, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants