-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insomnia: add aarch64-darwin build, sandbox builds #383533
base: master
Are you sure you want to change the base?
Conversation
Insomnia has been supported on apple silicon since 2022, so nixpkgs should support it too. Switch to using undmg to unpack the upstream .dmg so sandboxed builds complete successfully on macos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! I can't test it, can you post the results of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 383533"
please? Thanks! I'll post the result for amd64 Linux today 👍.
Result of {
"blacklisted": [],
"broken": [],
"built": [],
"extra-nixpkgs-config": null,
"failed": [],
"non-existent": [],
"pr": 383533,
"system": "aarch64-darwin",
"tests": []
} @DataHearth I'm not too familiar with nixpkgs-review, should there be no builds listed when running against the PR? Running {
"blacklisted": [],
"broken": [],
"built": [
"insomnia"
],
"extra-nixpkgs-config": null,
"failed": [],
"non-existent": [],
"pr": null,
"system": "aarch64-darwin",
"tests": []
} |
Not really. I also get this behaviour sometimes. Mostly with old versions of |
@mikansoro you could become a maintainer if you're using often on this arch. This would help a lot 😄 ! |
I'm not opposed to being added, but I don't use it regularly. Some folk at $work do and we're slowly adopting nix for devs. Figured I'd put in a PR if it wasn't too much work to build 😄. If you'd like to have me on as a tester for apple silicon anyway though, then sure 🙂 |
Aha, that was it. Thanks! Turns out I'd never updated my mac from 24.05 when I updated the rest of my machines. oops. --------- Report for 'aarch64-darwin' ---------
|
Insomnia has been supported on apple silicon since 2022, so nixpkgs should support it too.
Switch to using
undmg
to unpack the source.dmg
file instead of mounting it, so sandboxed builds complete successfully on macos.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.