Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insomnia: add aarch64-darwin build, sandbox builds #383533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikansoro
Copy link

Insomnia has been supported on apple silicon since 2022, so nixpkgs should support it too.

Switch to using undmg to unpack the source .dmg file instead of mounting it, so sandboxed builds complete successfully on macos.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Insomnia has been supported on apple silicon since 2022, so nixpkgs should
support it too.

Switch to using undmg to unpack the upstream .dmg so sandboxed builds
complete successfully on macos.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 20, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 20, 2025
Copy link
Contributor

@DataHearth DataHearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I can't test it, can you post the results of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 383533" please? Thanks! I'll post the result for amd64 Linux today 👍.

@mikansoro
Copy link
Author

Result of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 383533"

{
    "blacklisted": [],
    "broken": [],
    "built": [],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existent": [],
    "pr": 383533,
    "system": "aarch64-darwin",
    "tests": []
}

@DataHearth I'm not too familiar with nixpkgs-review, should there be no builds listed when running against the PR? Running nixpkgs-review rev HEAD against my branch notes insomnia as built:

{
    "blacklisted": [],
    "broken": [],
    "built": [
        "insomnia"
    ],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existent": [],
    "pr": null,
    "system": "aarch64-darwin",
    "tests": []
}

@DataHearth
Copy link
Contributor

Result of nix-shell -p nixpkgs-review --run "nixpkgs-review pr 383533"

{
    "blacklisted": [],
    "broken": [],
    "built": [],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existent": [],
    "pr": 383533,
    "system": "aarch64-darwin",
    "tests": []
}

@DataHearth I'm not too familiar with nixpkgs-review, should there be no builds listed when running against the PR? Running nixpkgs-review rev HEAD against my branch notes insomnia as built:

{
    "blacklisted": [],
    "broken": [],
    "built": [
        "insomnia"
    ],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existent": [],
    "pr": null,
    "system": "aarch64-darwin",
    "tests": []
}

Not really. I also get this behaviour sometimes. Mostly with old versions of nixpkgs-review. You can check which channel is being used and/or update it. But hey, I trust you, if you built it locally with nixpkgs-review rev HEAD, great! LGTM!

@DataHearth
Copy link
Contributor

@mikansoro you could become a maintainer if you're using often on this arch. This would help a lot 😄 !

@mikansoro
Copy link
Author

I'm not opposed to being added, but I don't use it regularly. Some folk at $work do and we're slowly adopting nix for devs. Figured I'd put in a PR if it wasn't too much work to build 😄.

If you'd like to have me on as a tester for apple silicon anyway though, then sure 🙂

@mikansoro
Copy link
Author

Mostly with old versions of nixpkgs-review

Aha, that was it. Thanks! Turns out I'd never updated my mac from 24.05 when I updated the rest of my machines. oops.

--------- Report for 'aarch64-darwin' ---------
1 package built:
insomnia

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383533


aarch64-darwin

✅ 1 package built:
  • insomnia

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants