zluda: 3 -> 4-unstable-2025-01-28

[DerDennisOP]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SuperSandro2000]

LGTM, lets wait a few days for the maintainer

[errnoh]

Sadly I don't have a good setup to test this right now, feel free to move forward with the merge. I'm in process of trying to get the environment set up again in the future.

(but glad to see that we can remove the cargo duct tape)

Btw it's not like I'm that committed on this package myself, I just happened to be interested in building it originally. If there are people interested in taking over the maintainership I'm ok passing it forward (or sharing it).

[SuperSandro2000]

Do we need the mlir update for this to build?

In file included from /build/source/mlir/lib/Dialect/Rock/Transforms/ViewToTransform.cpp:14:
/build/source/mlir/include/mlir/Conversion/TosaToRock/TosaToRock.h:21:10: fatal error: 'mlir/Conversion/RocMLIRPasses.h.inc' file not found
#include "mlir/Conversion/RocMLIRPasses.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

[DerDennisOP]

Do we need the mlir update for this to build?

In file included from /build/source/mlir/lib/Dialect/Rock/Transforms/ViewToTransform.cpp:14:
/build/source/mlir/include/mlir/Conversion/TosaToRock/TosaToRock.h:21:10: fatal error: 'mlir/Conversion/RocMLIRPasses.h.inc' file not found
#include "mlir/Conversion/RocMLIRPasses.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

zluda3 is broken, so I updated it.

[SuperSandro2000]

sure, but rocmlir-rock through miopen doesn't compile so I can't test this.

[DerDennisOP]

sure, but rocmlir-rock through miopen doesn't compile so I can't test this.

Yeah i tested it with the rocm update. It will build with the new version. You should be able to safely merge it