Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-graft, gg: merge duplicated package #387824

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Mar 7, 2025

cc @XYenon
Related: #287770

This pr merges two duplicated packages and creates an alias for backward compacity and easier recognition.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 7, 2025
@nix-owners nix-owners bot requested a review from XYenon March 7, 2025 08:55
@oluceps
Copy link
Member Author

oluceps commented Mar 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387824


x86_64-linux

✅ 1 package built:
  • go-graft

@oluceps oluceps added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 7, 2025
@Aleksanaa Aleksanaa merged commit 8a97acd into NixOS:master Mar 7, 2025
27 of 28 checks passed
@oluceps oluceps deleted the gg-gograft branch March 7, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants