-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elm 0.19 #45448
Elm 0.19 #45448
Conversation
@GrahamcOfBorg build elmPackages.elm |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: elmPackages.elm Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: elmPackages.elm Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: elmPackages.elm Partial log (click to expand)
|
I tried some things in jerith666@815b837 to avoid the http request to https://package.elm-lang.org/all-packages, but it's still happening. Maybe my flailing will inspire someone else ... ? |
Poking around some more in the source code, I think what we're missing is a |
update makeElmStuff to makeDotElm, create elm-elm.nix listing the elm code that elm itself embeds, and pre-fetch it so that the elm build can function offline. also include a versions.dat file, as created during an impure build of elm. set ELM_HOME so that the elm build can find these things. continues NixOS#45448
Yes, that was the key! jerith666@e7d0df8 builds! I haven't looked at |
@GrahamcOfBorg build elmPackages.elm |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: elmPackages.elm Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: elmPackages.elm Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: elmPackages.elm Partial log (click to expand)
|
elm-interface-to-json is not released yet, so only elm-format missing. |
Elm-interface-json seems a bit unmaintaned. I suggest just removing it untill they update to elm 0.19. I tried getting a new elm-format ready with cabal2nix but I was running into dependency he'll because elm-format depends on a too old version of the |
Maybe the borg build failure is because you haven't fast-forwarded your |
I had to do some special handling for |
I'd prefer if we fix it upstream, unless it's a major change. |
update makeElmStuff to makeDotElm, create elm-elm.nix listing the elm code that elm itself embeds, and pre-fetch it so that the elm build can function offline. also include a versions.dat file, as created during an impure build of elm. set ELM_HOME so that the elm build can find these things. continues NixOS#45448 (cherry picked from commit e7d0df8) Signed-off-by: Domen Kožar <domen@dev.si>
OK the upstream is hard to fix, working on a workaround. |
I've already got a fix! I partially reverted one of your commits (arianvp@37d4066) I also updated the https://github.com/arianvp/nixpkgs/tree/elm-0.19-wip |
Could you update this branch to point to my latest version of it? Then we can let ofborg do its thing and merge. |
Before we merge, we need reproducable updates, right now |
@GrahamcOfBorg build elmPackages |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: elmPackages Partial log (click to expand)
|
Once we add instructions for |
Success on x86_64-darwin (full log) Attempted: elmPackages Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: elmPackages Partial log (click to expand)
|
instructions for |
(cherry picked from commit fcabcb2) Signed-off-by: Domen Kožar <domen@dev.si>
You rock :) |
update makeElmStuff to makeDotElm, create elm-elm.nix listing the elm code that elm itself embeds, and pre-fetch it so that the elm build can function offline. also include a versions.dat file, as created during an impure build of elm. set ELM_HOME so that the elm build can find these things. continues #45448 (cherry picked from commit e7d0df8) Signed-off-by: Domen Kožar <domen@dev.si>
WIP, it's now stuck trying to download elm packages for reactor.
I won't have time to work on this, hopefully someone can pick it up before 18.09 forks off.
Fixes #15800