pythonPackages.pytest: fix .pytest_cache, again #45898
Conversation
| @@ -29,7 +29,7 @@ buildPythonPackage rec { | |||
|
|
|||
| # Remove .pytest_cache when using py.test in a Nix build | |||
| setupHook = writeText "pytest-hook" '' | |||
| postFixupHooks+=( | |||
| postCheckHooks+=( | |||
There was a problem hiding this comment.
At the moment we do not run this for most manual pytest check phases. Does this mean we have to add runHook to every python package with pytest now?
There was a problem hiding this comment.
This is a bit boiler code one has to remember.
There was a problem hiding this comment.
Yes, we would have to, unless we get NixOS/rfcs#32. The other option is to set PYTEST_ADDOPTS again with nocacheprovider. This will, however, break packages that require it, so in those cases we would have to unset PYTEST_ADDOPTS.
Neither option is nice, but I prefer us to do what upstream documents, "the cache is created by default", even though it affects reproducibility and causes issues with python.buildEnv.
There was a problem hiding this comment.
Before NixOS/rfcs#32 the non-boilerplate option to add this to a custom phase instead and put that phase into $preInstallPhases.
There was a problem hiding this comment.
Because the installPhases are to early I added a preDistPhase.
It was reported that the 2nd solution wasn't working as expected because it was ran in the wrong phase. This commit creates a new phase, in between the installCheckPhase and distPhase.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)