-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roccat-tools: init at 5.7.0 #45959
roccat-tools: init at 5.7.0 #45959
Conversation
@GrahamcOfBorg build roccat-tools |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: roccat-tools Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: roccat-tools Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: roccat-tools Partial log (click to expand)
|
Greetings to the NixOS dev team! I'm a friend of @ashkitten , who submitted this PR on September 2. Apparently PR #47493, which addresses the same problem, was submitted on September 28 and immediately merged, despite the fact that this PR (45959) had been checked and ready to merge since September 10, resulting in significant duplication/waste of effort. Some questions come to mind:
I'm just concerned that there's some kind of failure of process here which may be leading to a lot of wasted effort, if this sort of thing is at all a common occurrence. Thank you for your consideration. |
Really sorry about that! The last couple of months have seen a huge influx of PRs and quite a few of these got ignored.
It's definitely something that needs to be improved. Right now the process is pretty messy & you will find some PRs getting merged almost immediately and others take a long time. |
Motivation for this change
i made the package for myself and figured it's nice to share.
i'm new to all this stuff so i didn't make a 25-way split package like the aur. if that's a thing yall want i guess let me know how to do it and i will?
i also patched it to put its files in
$XDG_CONFIG_HOME
instead of/var/lib
, because i'm not sure how i'd make it work with/var/lib
and it seemed like a weird place anyways.i don't own all the devices this supports, so i wasn't able to test everything, though it seemed to work fine with my ryosmkfx and tyon.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)