Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roccat-tools: init at 5.7.0 #45959

Closed
wants to merge 1 commit into from
Closed

Conversation

ashkitten
Copy link
Contributor

Motivation for this change

i made the package for myself and figured it's nice to share.

i'm new to all this stuff so i didn't make a 25-way split package like the aur. if that's a thing yall want i guess let me know how to do it and i will?

i also patched it to put its files in $XDG_CONFIG_HOME instead of /var/lib, because i'm not sure how i'd make it work with /var/lib and it seemed like a weird place anyways.

i don't own all the devices this supports, so i wasn't able to test everything, though it seemed to work fine with my ryosmkfx and tyon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 2, 2018
@matthewbauer
Copy link
Member

@GrahamcOfBorg build roccat-tools

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: roccat-tools

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: roccat-tools

Partial log (click to expand)

shrinking /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/bin/roccatryosmkconfig
shrinking /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/bin/roccatluaconfig
shrinking /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/bin/roccatarvoconfig
shrinking /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/bin/roccateventhandler
shrinking /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/bin/roccatsovacontrol
gzipping man pages under /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/lib  /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0/bin
patching script interpreter paths in /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0
checking for references to /build in /nix/store/xm3wjz6ywqd246scbck6g4qwvb7pscng-roccat-tools-5.7.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: roccat-tools

Partial log (click to expand)

shrinking /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/lib/roccat/libarvoeventhandler.so
shrinking /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/lib/libroccatarvo.so.5.7.0
shrinking /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/lib/libroccatwidget.so.5.7.0
shrinking /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/lib/libroccat.so.5.7.0
gzipping man pages under /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/lib  /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0/bin
patching script interpreter paths in /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0
checking for references to /build in /nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0...
/nix/store/xldc09fgc0kizfsja60l7f1rszlvglh5-roccat-tools-5.7.0

@woozalia
Copy link

woozalia commented Oct 4, 2018

Greetings to the NixOS dev team!

I'm a friend of @ashkitten , who submitted this PR on September 2. Apparently PR #47493, which addresses the same problem, was submitted on September 28 and immediately merged, despite the fact that this PR (45959) had been checked and ready to merge since September 10, resulting in significant duplication/waste of effort.

Some questions come to mind:

  • Q1 Is there anything ash could have done differently in order to draw attention to this PR so as to avoid the duplication of effort?
  • Q2 Is it common for PRs to be left this long without being either merged or rejected?
  • Q3 Is there anyone on the dev team whose role it is to check through checked PRs and either merge or reject them?

I'm just concerned that there's some kind of failure of process here which may be leading to a lot of wasted effort, if this sort of thing is at all a common occurrence.

Thank you for your consideration.

@matthewbauer
Copy link
Member

matthewbauer commented Oct 5, 2018

Really sorry about that! The last couple of months have seen a huge influx of PRs and quite a few of these got ignored.

  1. I would say the best thing is to try to remind someone who is listed as Member in the NixOS org. For this case, I honestly forgot that I had done a build of it. So either bugging people on IRC, Discourse, or GitHub is the best road right now.
  2. Unfortunately, yes, but we almost always try to get to them eventually. It's going to depend on what the software is that you are packaging and whether there is someone interested in it. I definitely understand the annoyance with this process because it is extremely chaotic. I am usually active so feel free to ping me when something gets forgotten about like this one was.
  3. Not really. NixOS is entirely a community driven OS so it is all going to depend on volunteers. There are about 100+ people with commit access but only a few are highly active. I think introducing something like this could be useful, but remember that everyone here has a day job/school/etc. and reviewing things can become very time intensive. I proposed an "automated" merging system here that you may find interesting: Feature Request: Automatic merging ofborg#104.

It's definitely something that needs to be improved. Right now the process is pretty messy & you will find some PRs getting merged almost immediately and others take a long time.

@ashkitten ashkitten closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants